You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Abdullah Shaikh (JIRA)" <ji...@apache.org> on 2009/11/25 14:32:39 UTC
[jira] Created: (OFBIZ-3260) Added drop down options replacing text
box to configure sagepay
Added drop down options replacing text box to configure sagepay
---------------------------------------------------------------
Key: OFBIZ-3260
URL: https://issues.apache.org/jira/browse/OFBIZ-3260
Project: OFBiz
Issue Type: Improvement
Reporter: Abdullah Shaikh
Priority: Minor
Added drop down options, replacing text box, to configure SagePay payment gateway transaction types settings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3260) Added drop down options replacing
text box to configure sagepay
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782519#action_12782519 ]
Jacques Le Roux commented on OFBIZ-3260:
----------------------------------------
Hi Abdullah,
Your patch looks good, but please before creating new labels check that they don't already exist, for instance those one exist in OFBiz
<value xml:lang="en">Payment</value>
<value xml:lang="en">Deferred</value>
<value xml:lang="en">Release</value>
<value xml:lang="en">Cancel</value>
<value xml:lang="en">Abort</value>
Also it should be better to create the others in Common
Thanks
> Added drop down options replacing text box to configure sagepay
> ---------------------------------------------------------------
>
> Key: OFBIZ-3260
> URL: https://issues.apache.org/jira/browse/OFBIZ-3260
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Abdullah Shaikh
> Priority: Minor
> Attachments: OFBIZ-3260_Added drop down options replacing text box.patch
>
>
> Added drop down options, replacing text box, to configure SagePay payment gateway transaction types settings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3260) Added drop down options replacing text
box to configure sagepay
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abdullah Shaikh updated OFBIZ-3260:
-----------------------------------
Attachment: OFBIZ-3260_Added drop down options replacing text box.patch
Added labels to CommonUiLabels.xml so that it can used from any application
> Added drop down options replacing text box to configure sagepay
> ---------------------------------------------------------------
>
> Key: OFBIZ-3260
> URL: https://issues.apache.org/jira/browse/OFBIZ-3260
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Abdullah Shaikh
> Priority: Minor
> Attachments: OFBIZ-3260_Added drop down options replacing text box.patch, OFBIZ-3260_Added drop down options replacing text box.patch
>
>
> Added drop down options, replacing text box, to configure SagePay payment gateway transaction types settings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-3260) Added drop down options
replacing text box to configure sagepay
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786490#action_12786490 ]
Jacques Le Roux edited comment on OFBIZ-3260 at 12/5/09 10:22 PM:
------------------------------------------------------------------
Hi Abdullah,
You don't need to use the labels of an application if a more general labels exist.
I agree about (I thought there were in CommonUiLabels.xml and did not check details)
<value xml:lang="en">Deferred</value>
<value xml:lang="en">Release</value>
<value xml:lang="en">Abort</value>
and I would suggest to create entries in common for that. Because it's not specifically related to a domain (like accounting) and may be also used, say in Order or Party applications. Note that you may use existing translations in CommonEntityLabels.xml for these new labels.
Also for instance<value xml:lang="en">Cancel</value>
exists in CommonUiLabels.xml and is already translated there in a dozen of languages. I guess you get my point.
Thanks
Edit: ********typo not is not note***********
was (Author: jacques.le.roux):
Hi Abdullah,
You don't need to use the labels of an application if a more general labels exist.
I agree about (I thought there were in CommonUiLabels.xml and did not check details)
<value xml:lang="en">Deferred</value>
<value xml:lang="en">Release</value>
<value xml:lang="en">Abort</value>
and I would suggest to create entries in common for that. Because it's not specifically related to a domain (like accounting) and may be also used, say in Order or Party applications. Not that you may use existing translations in CommonEntityLabels.xml for these new labels.
Also for instance<value xml:lang="en">Cancel</value>
exists in CommonUiLabels.xml and is already translated there in a dozen of languages. I guess you get my point.
Thanks
> Added drop down options replacing text box to configure sagepay
> ---------------------------------------------------------------
>
> Key: OFBIZ-3260
> URL: https://issues.apache.org/jira/browse/OFBIZ-3260
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Abdullah Shaikh
> Priority: Minor
> Attachments: OFBIZ-3260_Added drop down options replacing text box.patch
>
>
> Added drop down options, replacing text box, to configure SagePay payment gateway transaction types settings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3260) Added drop down options replacing
text box to configure sagepay
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786490#action_12786490 ]
Jacques Le Roux commented on OFBIZ-3260:
----------------------------------------
Hi Abdullah,
You don't need to use the labels of an application if a more general labels exist.
I agree about (I thought there were in CommonUiLabels.xml and did not check details)
<value xml:lang="en">Deferred</value>
<value xml:lang="en">Release</value>
<value xml:lang="en">Abort</value>
and I would suggest to create entries in common for that. Because it's not specifically related to a domain (like accounting) and may be also used, say in Order or Party applications. Not that you may use existing translations in CommonEntityLabels.xml for these new labels.
Also for instance<value xml:lang="en">Cancel</value>
exists in CommonUiLabels.xml and is already translated there in a dozen of languages. I guess you get my point.
Thanks
> Added drop down options replacing text box to configure sagepay
> ---------------------------------------------------------------
>
> Key: OFBIZ-3260
> URL: https://issues.apache.org/jira/browse/OFBIZ-3260
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Abdullah Shaikh
> Priority: Minor
> Attachments: OFBIZ-3260_Added drop down options replacing text box.patch
>
>
> Added drop down options, replacing text box, to configure SagePay payment gateway transaction types settings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3260) Added drop down options replacing
text box to configure sagepay
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785914#action_12785914 ]
Abdullah Shaikh commented on OFBIZ-3260:
----------------------------------------
Hi Jacques,
Yes I found already existing label as below :
Payment - AccountingPayment
Deferred - StatusItem.description.HR_DS_DEFERRED
Release - Enumeration.description.PGT_RELEASE
Cancel - StatusValidChange.transitionName.CAL_ACCEPTED.CAL_CANCELLED
may be there are more label for same string with different keys.
For my purpose AccountPayment for Payment string sounds good, but others I guess won't be nice to fit in.
So what do you suggest, should I put all of them in Accounting as :
AccountingDeferred
AccountingRelease
AccountingCancel so on ..
or in Common and if in common what should be the key pattern here.
Let me know your thoughts on this.
Thanks
> Added drop down options replacing text box to configure sagepay
> ---------------------------------------------------------------
>
> Key: OFBIZ-3260
> URL: https://issues.apache.org/jira/browse/OFBIZ-3260
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Abdullah Shaikh
> Priority: Minor
> Attachments: OFBIZ-3260_Added drop down options replacing text box.patch
>
>
> Added drop down options, replacing text box, to configure SagePay payment gateway transaction types settings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3260) Added drop down options replacing text
box to configure sagepay
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abdullah Shaikh updated OFBIZ-3260:
-----------------------------------
Attachment: OFBIZ-3260_Added drop down options replacing text box.patch
> Added drop down options replacing text box to configure sagepay
> ---------------------------------------------------------------
>
> Key: OFBIZ-3260
> URL: https://issues.apache.org/jira/browse/OFBIZ-3260
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Abdullah Shaikh
> Priority: Minor
> Attachments: OFBIZ-3260_Added drop down options replacing text box.patch
>
>
> Added drop down options, replacing text box, to configure SagePay payment gateway transaction types settings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.