[GitHub] [guacamole-client] mike-jumper commented on issue #406: GUACAMOLE-643: Show connection groups during filter operations

[GitBox <gi...@apache.org>]

mike-jumper commented on issue #406: GUACAMOLE-643: Show connection groups during filter operations
URL: https://github.com/apache/guacamole-client/pull/406#issuecomment-493989442
 
 
   1. Beware that your pull request includes three commits with identical commit messages.
   2. I don't believe adding a new attribute that makes connection groups oblivious to filtering is a good approach to the need described by GUACAMOLE-643; it's too hacky. Assuming that JIRA issue is something that should be improved, discussion on the approach is needed. One such alternative approach might be to alter the way the flattened connections are rendered such that they can be distinguished despite being in separate groups.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services