You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/17 19:47:03 UTC
[GitHub] [airflow] Goodkat opened a new pull request #14860: Better "dependency already registered" warning message #14613
Goodkat opened a new pull request #14860:
URL: https://github.com/apache/airflow/pull/14860
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#issuecomment-801373609
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Goodkat commented on pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
Goodkat commented on pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#issuecomment-801416674
It is related to the issue #14613, and as it is stated there, it would be nice if the warning message included also the dag information, so we would have more of an idea where (in which dag) it is happening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Goodkat commented on pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
Goodkat commented on pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#issuecomment-821967481
I requested a review 22 days ago.
Could anyone have a look?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14860:
URL: https://github.com/apache/airflow/pull/14860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#issuecomment-801400154
Can you add a description explaining what this PR does, why is it required, etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#issuecomment-822321084
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#issuecomment-805267065
[The Workflow run](https://github.com/apache/airflow/actions/runs/680991743) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#discussion_r599846815
##########
File path: airflow/models/baseoperator.py
##########
@@ -1158,10 +1158,10 @@ def task_type(self) -> str:
"""@property: type of the task"""
return self.__class__.__name__
- def add_only_new(self, item_set: Set[str], item: str) -> None:
+ def add_only_new(self, item_set: Set[str], item: str, dag_info: str) -> None:
Review comment:
```suggestion
def add_only_new(self, item_set: Set[str], item: str, dag_id: str) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#issuecomment-822321057
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #14860: Better "dependency already registered" warning message #14613
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #14860:
URL: https://github.com/apache/airflow/pull/14860#discussion_r600012211
##########
File path: airflow/models/baseoperator.py
##########
@@ -1158,10 +1158,10 @@ def task_type(self) -> str:
"""@property: type of the task"""
return self.__class__.__name__
- def add_only_new(self, item_set: Set[str], item: str) -> None:
+ def add_only_new(self, item_set: Set[str], item: str, dag_id: str) -> None:
"""Adds only new items to item set"""
if item in item_set:
- self.log.warning('Dependency %s, %s already registered', self, item)
+ self.log.warning('Dependency %s, %s already registered for DAG: %s', self, item, dag_info)
Review comment:
I think if we change `dag_info` to `dag_id` we should do this in both places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org