[jira] [Closed] (MNG-6999) Chained (consumer) XMLFilters can result in "floating" comments

["Robert Scholte (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MNG-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte closed MNG-6999.
-------------------------------
    Fix Version/s: 3.7.0
       Resolution: Fixed

Fixed in [e7eef9d34f15a5da5c36f51fea11dc645875d143|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=e7eef9d34f15a5da5c36f51fea11dc645875d143]

> Chained (consumer) XMLFilters can result in "floating" comments
> ---------------------------------------------------------------
>
>                 Key: MNG-6999
>                 URL: https://issues.apache.org/jira/browse/MNG-6999
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>            Priority: Major
>             Fix For: 3.7.0
>
>
> Discovered while working on MNG-6957: I wanted to do the following:
> {code:xml}
> <modules>
>   <module>Z</module>
>   <module>A</module> <!-- on purpose in reverse order -->
> </modules>
> {code}
> The ModulesXMLFilterTest contains tests related to comments, but when filters are changed, the lexicalHandlers are not chained correctly.
> The result: cleaned up modules, but leaving a comment behind.
> {code:xml}
> <!-- on purpose in reverse order -->
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)