You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Claude Brisson (JIRA)" <de...@velocity.apache.org> on 2018/06/26 23:34:00 UTC

[jira] [Commented] (VELTOOLS-103) ImportSupport really needs a unit test

    [ https://issues.apache.org/jira/browse/VELTOOLS-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524337#comment-16524337 ] 

Claude Brisson commented on VELTOOLS-103:
-----------------------------------------

Eons later... well it seems that the ImportSupport has some test cases, now. Your library may still be useful, but:
 * I get an error when running ant tests on the 1.0a:

[junit] Caused by: java.net.MalformedURLException: no !/ found in url spec:testurl:getJarEntry!file_in_jar.txt
 [junit] at java.net.JarURLConnection.parseSpecs(JarURLConnection.java:172)
 [junit] at java.net.JarURLConnection.<init>(JarURLConnection.java:158)
 [junit] at org.tuc.testurl.DelegatingJarURLConnection.<init>(DelegatingJarURLConnection.java:65)
 [junit] at org.tuc.testurl.Handler.openConnection(Handler.java:45)
 [junit] at java.net.URL.openConnection(URL.java:979)
 [junit] at org.tuc.testurl.DelegatingURLConnectionTests.testDelegateMethods(DelegatingURLConnectionTests.java:66)
 * It would be better to have a maven artifact. Maybe using [https://jitpack.io/] ?

> ImportSupport really needs a unit test
> --------------------------------------
>
>                 Key: VELTOOLS-103
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-103
>             Project: Velocity Tools
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 1.4, 2.0, 2.x
>         Environment: All
>            Reporter: Christopher Schultz
>            Priority: Minor
>         Attachments: VELTOOLS-103.zip
>
>
> ImportSupport needs a unit test.
> I wrote one a while ago, but it depends upon a (small) library that I wrote. I have since released that library under the Apache License V2.0 on SourceForge.net (http://sourceforge.net/projects/tuc). If the team is okay with including this library as a test-time dependency, I can submit a working unit test very quickly (just have to update it to 2.0-standards, if anything).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org