[GitHub] [sling-org-apache-sling-xss] rombert commented on pull request #32: SLING-11610 - Sling XSS API 2.3.0 does not work on Java 17

["rombert (via GitHub)" <gi...@apache.org>]

rombert commented on PR #32:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/32#issuecomment-1592933911

   I've tried to set this up in a way that works with Java 8 through 21. I think the code is working fine, the problem is the build.
   
   In [29c1733](https://github.com/apache/sling-org-apache-sling-xss/pull/32/commits/29c17330cf81c36331f13b01b93a9cf381994bc0) I see Java 11, 17 and 21 builds passing. I've reconfigured the project for Java 8 in [674c7cb](https://github.com/apache/sling-org-apache-sling-xss/pull/32/commits/674c7cb1c68205120545638788657ce3af809b35), but at that point Java 11+ builds start failing with 
   
   > option --add-modules not allowed with target 1.8
   
   That error makes sense, since the JPMS has been introduced with Java 9.
   
   I think supporting Java 11, 17, and 21 is preferred to only supporting Java 8 and 11, but I don't have an idea about how to fix the build.
   
   @kwin - maybe you have an idea? I know you've worked on the parent POM plumbing for the compiler plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org