You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2012/07/04 15:12:33 UTC

[jira] [Created] (OAK-165) NodeDelegate should not use Tree.getChild() but rather Root.getTree()

Michael Dürig created OAK-165:
---------------------------------

             Summary: NodeDelegate should not use Tree.getChild() but rather Root.getTree()
                 Key: OAK-165
                 URL: https://issues.apache.org/jira/browse/OAK-165
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: jcr
         Environment: {{Tree.getChild()}} is problematic wrt. to access control. {{Root.getTree()}} should be used instead. 
            Reporter: Michael Dürig
            Assignee: Michael Dürig




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OAK-165) NodeDelegate should not use Tree.getChild() but rather Root.getTree()

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406535#comment-13406535 ] 

Jukka Zitting commented on OAK-165:
-----------------------------------

I understand where this is coming from (access control), but I'm concerned that as a result we now have to repeatedly resolve the full path every time we want to access something. In practice all the relevant information will already be cached in memory, so it may not be that much of a problem, but we're still adding path parsing and resolution steps to a place where they wouldn't really be necessary.
                
> NodeDelegate should not use Tree.getChild() but rather Root.getTree()
> ---------------------------------------------------------------------
>
>                 Key: OAK-165
>                 URL: https://issues.apache.org/jira/browse/OAK-165
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>         Environment: {{Tree.getChild()}} is problematic wrt. to access control. {{Root.getTree()}} should be used instead. 
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>             Fix For: 0.4
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OAK-165) NodeDelegate should not use Tree.getChild() but rather Root.getTree()

Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406543#comment-13406543 ] 

Michael Dürig commented on OAK-165:
-----------------------------------

I share these concerns. However I don't see a better solution as long as we want to be able to restrict access to parent nodes. The changes introduces through this issues a pretty trivial so we can easily undo/refactor them once we have a clearer picture of access control. 
                
> NodeDelegate should not use Tree.getChild() but rather Root.getTree()
> ---------------------------------------------------------------------
>
>                 Key: OAK-165
>                 URL: https://issues.apache.org/jira/browse/OAK-165
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>         Environment: {{Tree.getChild()}} is problematic wrt. to access control. {{Root.getTree()}} should be used instead. 
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>             Fix For: 0.4
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (OAK-165) NodeDelegate should not use Tree.getChild() but rather Root.getTree()

Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-165.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.4

Fixed at revision 1357267
                
> NodeDelegate should not use Tree.getChild() but rather Root.getTree()
> ---------------------------------------------------------------------
>
>                 Key: OAK-165
>                 URL: https://issues.apache.org/jira/browse/OAK-165
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>         Environment: {{Tree.getChild()}} is problematic wrt. to access control. {{Root.getTree()}} should be used instead. 
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>             Fix For: 0.4
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira