You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by ilooner <gi...@git.apache.org> on 2016/04/06 06:56:26 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
GitHub user ilooner opened a pull request:
https://github.com/apache/incubator-apex-core/pull/296
APEXCORE-421 #comment #resolve Fixing double checkpoint bug on InputN…
…ode shutdown
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/incubator-apex-core APEXCORE-421
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit 753983979e0d625b9452185190427b1e669d2572
Author: Timothy Farkas <ti...@datatorrent.com>
Date: 2016-04-06T04:52:10Z
APEXCORE-421 #comment #resolve Fixing double checkpoint bug on InputNode shutdown
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/296#issuecomment-207132509
@chandnisingh added a comment about why the check is there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/296#issuecomment-206621280
@chandnisingh please review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/296#issuecomment-206129344
@sandeshh I agree, the problem is that this code is quite complex and there is almost no unit test coverage. I am afraid to do refactoring on code I don't completely understand, which is not sufficiently tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
Posted by sandeshh <gi...@git.apache.org>.
Github user sandeshh commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/296#issuecomment-206120906
If the checkpoint function is not properly used in 3 places, it is time to fix that as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/296#discussion_r58800303
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/InputNode.java ---
@@ -241,11 +241,14 @@ else if (PROCESSING_MODE == ProcessingMode.EXACTLY_ONCE) {
if (++applicationWindowCount == APPLICATION_WINDOW_COUNT) {
applicationWindowCount = 0;
}
- if (++checkpointWindowCount == CHECKPOINT_WINDOW_COUNT) {
- checkpointWindowCount = 0;
- if (doCheckpoint || PROCESSING_MODE == ProcessingMode.EXACTLY_ONCE) {
- checkpoint(currentWindowId);
- lastCheckpointWindowId = currentWindowId;
+
+ if (lastCheckpointWindowId < currentWindowId) {
--- End diff --
can we add a small comment here that why this check is needed?
It helps others to understand
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/296#issuecomment-206598592
@davidyan74 please review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-421 #comment #resolve F...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/296#issuecomment-206118367
@davidyan74 please review. There was another double checkpointing bug in InputNode which was causing my unit test to fail on travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---