[GitHub] [bookkeeper] lordcheng10 commented on pull request #3062: Support isolate read write thread pool

[GitBox <gi...@apache.org>]

lordcheng10 commented on PR #3062:
URL: https://github.com/apache/bookkeeper/pull/3062#issuecomment-1378153416

   > 1. 读取请求不会等待该线程池完成。
   > 
   > > 读取冷数据时，需要很长时间。这时候读请求会被阻塞，导致写超时。
   > 
   > 我可以看到一个测试重现这个吗？ 我怀疑问题出在其他地方。
   > 
   > 2. 那里的订购是有原因的。
   > 
   > 此 PR 中的测试根本不涵盖与实际功能相关的任何内容。我建议尝试默认启用该功能并运行所有测试以查看有什么问题，很难想出更具体的东西。
   > 
   > 3. 您是否对性能、相同负载、相同 bookies 等、功能关闭/打开进行了同类比较？
   
   
   
   > 1. read request doesn't wait for the completion on that threadpool.
   > 
   > > When cold data is read, it will take a long time. At this time, the read request will be blocked, resulting in the write timeout.
   > 
   > Can I see a test reproing this? i suspect the problem is somewhere else.
   > 
   > 2. The ordering there is required for a reason.
   > 
   > The test in this PR simply does not cover anything related to actual functionality. I suggest trying to enable the feature by default and running all tests to see what breaks, it's hard to come up with something more specific off the top of my head.
   > 
   > 3. Do you have apples-to-apples comparison of performance, same load, same bookies etc, the feature off/on?
   
   For ledgers in the Writable state, reading and writing share the same thread pool, and there is no way to isolate reading and writing;
   IMO, it is useful to isolate reads and writes to different threads of execution; @dlg99 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org