You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/06/19 01:51:45 UTC
[jira] Created: (THRIFT-39) javabean-style generated code is very
poorly formatted
javabean-style generated code is very poorly formatted
------------------------------------------------------
Key: THRIFT-39
URL: https://issues.apache.org/jira/browse/THRIFT-39
Project: Thrift
Issue Type: Bug
Components: Compiler (Java)
Reporter: Bryan Duxbury
Priority: Minor
The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-39) javabean-style generated code is very
poorly formatted
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624192#action_12624192 ]
Bryan Duxbury commented on THRIFT-39:
-------------------------------------
I've looked this over pretty thoroughly, and I can't seem to figure out what the cause is. Only some of my structs' indentation is being dropped, while others are completely fine. There's no apparent connection between the ones that work and the ones that don't.
For the moment, I'm stumped. If anyone else can think of a reason as to why indent() calls in the generator would be getting outright ignored, I'm all ears.
> javabean-style generated code is very poorly formatted
> ------------------------------------------------------
>
> Key: THRIFT-39
> URL: https://issues.apache.org/jira/browse/THRIFT-39
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Minor
>
> The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-39) javabean-style generated code is very
poorly formatted
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-39:
--------------------------------
Patch Info: [Patch Available]
I think this patch should be committed. Can a committer take a look?
> javabean-style generated code is very poorly formatted
> ------------------------------------------------------
>
> Key: THRIFT-39
> URL: https://issues.apache.org/jira/browse/THRIFT-39
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Piotr Kozikowski
> Priority: Trivial
> Attachments: thrift-39.patch
>
>
> The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-39) javabean-style generated code is very
poorly formatted
Posted by "Piotr Kozikowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piotr Kozikowski updated THRIFT-39:
-----------------------------------
Attachment: thrift-39.patch
I found it! Here is the patch. The fix required only one line of code. If you are curious, what caused this was that in certain situations a call was made to indent_down(), without a corresponding call to indent_up() somewhere before, giving the private variable indent_ a negative value, and making calls to indent() have no effect.
> javabean-style generated code is very poorly formatted
> ------------------------------------------------------
>
> Key: THRIFT-39
> URL: https://issues.apache.org/jira/browse/THRIFT-39
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Trivial
> Attachments: thrift-39.patch
>
>
> The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-39) javabean-style generated code is very
poorly formatted
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-39:
-----------------------------------
Assignee: Piotr Kozikowski
> javabean-style generated code is very poorly formatted
> ------------------------------------------------------
>
> Key: THRIFT-39
> URL: https://issues.apache.org/jira/browse/THRIFT-39
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Piotr Kozikowski
> Priority: Trivial
> Attachments: thrift-39.patch
>
>
> The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-39) javabean-style generated code is very
poorly formatted
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-39.
-------------------------------
Resolution: Fixed
> javabean-style generated code is very poorly formatted
> ------------------------------------------------------
>
> Key: THRIFT-39
> URL: https://issues.apache.org/jira/browse/THRIFT-39
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Piotr Kozikowski
> Priority: Trivial
> Attachments: thrift-39.patch
>
>
> The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-39) javabean-style generated code is very
poorly formatted
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648051#action_12648051 ]
Bryan Duxbury commented on THRIFT-39:
-------------------------------------
Wow, you are my hero.
> javabean-style generated code is very poorly formatted
> ------------------------------------------------------
>
> Key: THRIFT-39
> URL: https://issues.apache.org/jira/browse/THRIFT-39
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Trivial
> Attachments: thrift-39.patch
>
>
> The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-39) javabean-style generated code is very
poorly formatted
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-39:
--------------------------------
Priority: Trivial (was: Minor)
> javabean-style generated code is very poorly formatted
> ------------------------------------------------------
>
> Key: THRIFT-39
> URL: https://issues.apache.org/jira/browse/THRIFT-39
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Trivial
>
> The code that gets generated when you run thrift -javabean has no indentation in it at all. This makes it a little challenging to read through it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.