[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8748: [fix] Fixing time controls when switching datasource types

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8748: [fix] Fixing time controls when switching datasource types
URL: https://github.com/apache/incubator-superset/pull/8748#discussion_r353899247
 
 

 ##########
 File path: superset/assets/src/explore/reducers/exploreReducer.js
 ##########
 @@ -36,9 +36,31 @@ export default function exploreReducer(state = {}, action) {
       };
     },
     [actions.SET_DATASOURCE]() {
+      const newFormData = {...state.form_data};
+      if (action.datasource.type != state.datasource.type) {
 
 Review comment:
   nit: `!==`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org