[GitHub] [maven-surefire] ajohnstonTE commented on a change in pull request #267: [SUREFIRE-1741] JUnit5: Detect failed containers

[GitBox <gi...@apache.org>]

ajohnstonTE commented on a change in pull request #267: [SUREFIRE-1741] JUnit5: Detect failed containers
URL: https://github.com/apache/maven-surefire/pull/267#discussion_r370920432
 
 

 ##########
 File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
 ##########
 @@ -185,6 +188,13 @@ private SimpleReportEntry createReportEntry( TestIdentifier testIdentifier,
                 stw, elapsedTime, reason, systemProperties );
     }
 
+    private boolean isFailedContainer( TestIdentifier testIdentifier,
+                                      TestExecutionResult testExecutionResult )
+    {
+        return testIdentifier.isContainer() && testExecutionResult != null
 
 Review comment:
   I'll switch to a static import, but I do need the null check. The method directly below this one passes a null value for a `testExecutionResult` (which ultimately makes its way over to here): https://github.com/apache/maven-surefire/pull/267/files/38ad13f5a6a628282064d1b0976e1ea69a135b0e#diff-ad07b0c74885ecb3d687dcc85495e390R198-R201

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services