You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by bo...@apache.org on 2023/12/28 07:53:02 UTC
(kyuubi) branch master updated: [KYUUBI #5912] Cleanup unused config `kyuubi.frontend.thrift.http.allow.user.substitution`
This is an automated email from the ASF dual-hosted git repository.
bowenliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new b1e726dcf [KYUUBI #5912] Cleanup unused config `kyuubi.frontend.thrift.http.allow.user.substitution`
b1e726dcf is described below
commit b1e726dcf5264ac505470074f1b49c6965afaf37
Author: Bowen Liang <li...@gf.com.cn>
AuthorDate: Thu Dec 28 15:52:52 2023 +0800
[KYUUBI #5912] Cleanup unused config `kyuubi.frontend.thrift.http.allow.user.substitution`
# :mag: Description
## Issue References ๐
As decribed.
## Describe Your Solution ๐ง
Drop the unused config of KyuubiConf, which are never used and linked in source code and test code:
- FRONTEND_THRIFT_HTTP_ALLOW_USER_SUBSTITUTION: `kyuubi.frontend.thrift.http.allow.user.substitution`
## Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklists
## ๐ Author Self Checklist
- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
## ๐ Committer Pre-Merge Checklist
- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested
**Be nice. Be informative.**
Closes #5912 from bowenliang123/unused-configs.
Closes #5912
b938058b8 [Bowen Liang] update doc
9fd441dd0 [Bowen Liang] fix
9b0b31ee1 [Bowen Liang] cleanup unused config entries in KyuubiConf
Authored-by: Bowen Liang <li...@gf.com.cn>
Signed-off-by: Bowen Liang <li...@gf.com.cn>
---
docs/configuration/settings.md | 1 -
.../src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala | 8 --------
2 files changed, 9 deletions(-)
diff --git a/docs/configuration/settings.md b/docs/configuration/settings.md
index aadbdb565..8d973ba8c 100644
--- a/docs/configuration/settings.md
+++ b/docs/configuration/settings.md
@@ -248,7 +248,6 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.frontend.thrift.binary.ssl.disallowed.protocols | SSLv2,SSLv3 | SSL versions to disallow for Kyuubi thrift binary frontend. [...]
| kyuubi.frontend.thrift.binary.ssl.enabled | false | Set this to true for using SSL encryption in thrift binary frontend server. [...]
| kyuubi.frontend.thrift.binary.ssl.include.ciphersuites || A comma-separated list of include SSL cipher suite names for thrift binary frontend. [...]
-| kyuubi.frontend.thrift.http.allow.user.substitution | true | Allow alternate user to be specified as part of open connection request when using HTTP transport mode. [...]
| kyuubi.frontend.thrift.http.bind.host | (none) | Hostname or IP of the machine on which to run the thrift frontend service via http protocol. [...]
| kyuubi.frontend.thrift.http.bind.port | 10010 | Port of the machine on which to run the thrift frontend service via http protocol. [...]
| kyuubi.frontend.thrift.http.compression.enabled | true | Enable thrift http compression via Jetty compression support [...]
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
index 784b82cdd..0eee9f47d 100644
--- a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
+++ b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
@@ -743,14 +743,6 @@ object KyuubiConf {
.toSequence()
.createWithDefault(Nil)
- val FRONTEND_THRIFT_HTTP_ALLOW_USER_SUBSTITUTION: ConfigEntry[Boolean] =
- buildConf("kyuubi.frontend.thrift.http.allow.user.substitution")
- .doc("Allow alternate user to be specified as part of open connection" +
- " request when using HTTP transport mode.")
- .version("1.6.0")
- .booleanConf
- .createWithDefault(true)
-
val FRONTEND_PROXY_HTTP_CLIENT_IP_HEADER: ConfigEntry[String] =
buildConf("kyuubi.frontend.proxy.http.client.ip.header")
.doc("The HTTP header to record the real client IP address. If your server is behind a load" +