You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2018/05/11 18:36:15 UTC

svn commit: r1831439 - in /tomcat/trunk: java/org/apache/coyote/ajp/AjpProcessor.java webapps/docs/changelog.xml

Author: markt
Date: Fri May 11 18:36:15 2018
New Revision: 1831439

URL: http://svn.apache.org/viewvc?rev=1831439&view=rev
Log:
Log an error message if the AJP connector detects the the reverse proxy is sending AJP messages that are too large for the configured packetSize.

Modified:
    tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1831439&r1=1831438&r2=1831439&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Fri May 11 18:36:15 2018
@@ -547,10 +547,10 @@ public class AjpProcessor extends Abstra
             if (messageLength > message.getBuffer().length) {
                 // Message too long for the buffer
                 // Need to trigger a 400 response
-                throw new IllegalArgumentException(sm.getString(
-                        "ajpprocessor.header.tooLong",
-                        Integer.valueOf(messageLength),
-                        Integer.valueOf(buf.length)));
+                String msg = sm.getString("ajpprocessor.header.tooLong",
+                        Integer.valueOf(messageLength), Integer.valueOf(buf.length));
+                log.error(msg);
+                throw new IllegalArgumentException(msg);
             }
             read(buf, Constants.H_SIZE, messageLength, true);
             return true;

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1831439&r1=1831438&r2=1831439&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 11 18:36:15 2018
@@ -100,6 +100,11 @@
       <fix>
         Followup sync fix for NIO2 async IO blocking read/writes. (remm)
       </fix>
+      <fix>
+        Log an error message if the AJP connector detects the the reverse proxy
+        is sending AJP messages that are too large for the configured
+        <code>packetSize</code>. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Jasper">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org