You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/04/25 12:21:50 UTC
Review Request 58699: Remove docker java client from Log Search it
framework
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58699/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian Toader.
Bugs: AMBARI-20844
https://issues.apache.org/jira/browse/AMBARI-20844
Repository: ambari
Description
-------
Remove docker java client from it framework code - it does not work properly with docker for mac.
For now we will use scripts from the docker folder to start/stop the solr/logsearch/logfeeder container. Also we uses "localhost" as docker host, but of course that will be changed. (maybe it will be an env variable from Profile file or a script output from logsearch-docker.sh script)
- also contains some test fixes, and added forkCount=1, to run @AfterStoreis only once (do not run tests paralelly)
- use LBHttpClient for accessing Solr
- removed AMBARI_LOCATION environment variable (as its not needed, we can determine where the ambari repo is)
Diffs
-----
ambari-logsearch/ambari-logsearch-it/pom.xml be7ab57
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java 564972a
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 91e0b10
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/SolrSteps.java 7c72ca7
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story 5abe8b4
ambari-logsearch/docker/logsearch-docker.sh 1fdcd8c
Diff: https://reviews.apache.org/r/58699/diff/1/
Testing
-------
done
Thanks,
Oliver Szabo
Re: Review Request 58699: Remove docker java client from Log Search it
framework
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58699/#review172923
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On April 25, 2017, 12:21 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58699/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 12:21 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-20844
> https://issues.apache.org/jira/browse/AMBARI-20844
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove docker java client from it framework code - it does not work properly with docker for mac.
> For now we will use scripts from the docker folder to start/stop the solr/logsearch/logfeeder container. Also we uses "localhost" as docker host, but of course that will be changed. (maybe it will be an env variable from Profile file or a script output from logsearch-docker.sh script)
>
> - also contains some test fixes, and added forkCount=1, to run @AfterStoreis only once (do not run tests paralelly)
> - use LBHttpClient for accessing Solr
> - removed AMBARI_LOCATION environment variable (as its not needed, we can determine where the ambari repo is)
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-it/pom.xml be7ab57
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java 564972a
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 91e0b10
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/SolrSteps.java 7c72ca7
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story 5abe8b4
> ambari-logsearch/docker/logsearch-docker.sh 1fdcd8c
>
>
> Diff: https://reviews.apache.org/r/58699/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58699: Remove docker java client from Log Search it
framework
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58699/#review173022
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On April 25, 2017, 2:21 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58699/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 2:21 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-20844
> https://issues.apache.org/jira/browse/AMBARI-20844
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove docker java client from it framework code - it does not work properly with docker for mac.
> For now we will use scripts from the docker folder to start/stop the solr/logsearch/logfeeder container. Also we uses "localhost" as docker host, but of course that will be changed. (maybe it will be an env variable from Profile file or a script output from logsearch-docker.sh script)
>
> - also contains some test fixes, and added forkCount=1, to run @AfterStoreis only once (do not run tests paralelly)
> - use LBHttpClient for accessing Solr
> - removed AMBARI_LOCATION environment variable (as its not needed, we can determine where the ambari repo is)
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-it/pom.xml be7ab57
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java 564972a
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 91e0b10
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/SolrSteps.java 7c72ca7
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story 5abe8b4
> ambari-logsearch/docker/logsearch-docker.sh 1fdcd8c
>
>
> Diff: https://reviews.apache.org/r/58699/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58699: Remove docker java client from Log Search it
framework
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58699/#review172942
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 25, 2017, 12:21 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58699/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 12:21 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-20844
> https://issues.apache.org/jira/browse/AMBARI-20844
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove docker java client from it framework code - it does not work properly with docker for mac.
> For now we will use scripts from the docker folder to start/stop the solr/logsearch/logfeeder container. Also we uses "localhost" as docker host, but of course that will be changed. (maybe it will be an env variable from Profile file or a script output from logsearch-docker.sh script)
>
> - also contains some test fixes, and added forkCount=1, to run @AfterStoreis only once (do not run tests paralelly)
> - use LBHttpClient for accessing Solr
> - removed AMBARI_LOCATION environment variable (as its not needed, we can determine where the ambari repo is)
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-it/pom.xml be7ab57
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java 564972a
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 91e0b10
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/SolrSteps.java 7c72ca7
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story 5abe8b4
> ambari-logsearch/docker/logsearch-docker.sh 1fdcd8c
>
>
> Diff: https://reviews.apache.org/r/58699/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58699: Remove docker java client from Log Search it
framework
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58699/#review172958
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 25, 2017, 12:21 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58699/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 12:21 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-20844
> https://issues.apache.org/jira/browse/AMBARI-20844
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove docker java client from it framework code - it does not work properly with docker for mac.
> For now we will use scripts from the docker folder to start/stop the solr/logsearch/logfeeder container. Also we uses "localhost" as docker host, but of course that will be changed. (maybe it will be an env variable from Profile file or a script output from logsearch-docker.sh script)
>
> - also contains some test fixes, and added forkCount=1, to run @AfterStoreis only once (do not run tests paralelly)
> - use LBHttpClient for accessing Solr
> - removed AMBARI_LOCATION environment variable (as its not needed, we can determine where the ambari repo is)
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-it/pom.xml be7ab57
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java 564972a
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java 91e0b10
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/SolrSteps.java 7c72ca7
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story 5abe8b4
> ambari-logsearch/docker/logsearch-docker.sh 1fdcd8c
>
>
> Diff: https://reviews.apache.org/r/58699/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>