You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gilles Sadowski <gi...@gmail.com> on 2021/05/27 09:58:23 UTC

Re: [Math] FastMath missing methods from java.lang.Math...

Hi.

Le jeu. 27 mai 2021 à 11:32, Erik Svensson <Er...@nasdaq.com> a écrit :
>
> Howdy all!
>
>
>
> I’m comparing FastMath with java.lang.Math and I notice that FastMath is no longer Math-complete.
>
> Ie, jlM has methods that FastMath doesn’t have.

Incidentally, that's why the unit test suite fails when building with
JDK 9+ (when
"JAVA_HOME" is not set properly).

>
> FM is documented as ‘drop-in replacement’ so should the new jlM methods be added to FM?

Do you propose to write/port pure Java implementations for those?

Regards,
Gilles

> [...]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [Math] FastMath missing methods from java.lang.Math...

Posted by Gilles Sadowski <gi...@gmail.com>.
Le ven. 28 mai 2021 à 10:23, Erik Svensson <Er...@nasdaq.com> a écrit :
>
> https://issues.apache.org/jira/browse/MATH-1591
>
> Please check it out.
> I should base it on the modularized_master branch,

No, it is outdated (merged into "master").

> I take it?

Sure.

Functionality should go in module "commons-math-legacy-core"
(where "FastMath" was moved and renamed "AccurateMath").
Note that the "legacy" specifier refers to codes that depend on other
legacy codes ("legacy-core" still depends on "legacy-exception").
[Of course you are welcome to provide a fully refactored module.]

Regards,
Gilles

>> [...]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [Math] FastMath missing methods from java.lang.Math...

Posted by Erik Svensson <Er...@nasdaq.com>.
https://issues.apache.org/jira/browse/MATH-1591

Please check it out.
I should base it on the modularized_master branch, I take it?

Cheers

Erik Svensson
Principal Architect
Strategic Programs, Platform & Product Engineering
 <http://www.nasdaq.com/>
Desk
Mobile
Email
Address  
+ 46 8 405 66 39
+ 46 73 449 66 39
erik.svensson@nasdaq.com
Tullvaktsvägen 15, Stockholm
 <https://www.facebook.com/nasdaq/>
 <https://twitter.com/nasdaq>
 <https://www.linkedin.com/company/nasdaq>
 <https://www.instagram.com/nasdaq/>
 <https://www.pinterest.com/nasdaq/>
rewritetomorrow.com <http://rewritetomorrow.com/>
 

On 2021-05-27, 16:44, "Gilles Sadowski" <gi...@gmail.com> wrote:

    WARNING - External email; exercise caution.

    Le jeu. 27 mai 2021 à 13:53, Erik Svensson <Er...@nasdaq.com> a écrit :
    >
    >
    >
    > On 2021-05-27, 11:59, "Gilles Sadowski" <gi...@gmail.com> wrote:
    >
    >     WARNING - External email; exercise caution.
    >
    >     Hi.
    >
    >     Le jeu. 27 mai 2021 à 11:32, Erik Svensson <Er...@nasdaq.com> a écrit :
    >     >
    >     > Howdy all!
    >     >
    >     >
    >     >
    >     > I’m comparing FastMath with java.lang.Math and I notice that FastMath is no longer Math-complete.
    >     >
    >     > Ie, jlM has methods that FastMath doesn’t have.
    >
    >     Incidentally, that's why the unit test suite fails when building with
    >     JDK 9+ (when
    >     "JAVA_HOME" is not set properly).
    >
    >
    >     >
    >     > FM is documented as ‘drop-in replacement’ so should the new jlM methods be added to FM?
    >
    >     Do you propose to write/port pure Java implementations for those?
    >
    > I can do that.

    Great!
    Please create a JIRA report.[1]

    Thanks,
    Gilles

    [1] https://issues.apache.org/jira/browse/MATH

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
    For additional commands, e-mail: dev-help@commons.apache.org


*******************************************
CONFIDENTIALITY AND PRIVACY NOTICE: This e-mail and any attachments are for the exclusive and confidential use of the intended recipient and may constitute non-public information.  Personal data in this email is governed by our Privacy Policy at  https://www.nasdaq.com/privacy-statement  unless explicitly excluded from it; please see the section in the policy entitled “Situations Where This Privacy Policy Does Not Apply” for circumstances where different privacy terms govern emailed personal data.  If you received this e-mail in error, disclosing, copying, distributing or taking any action in reliance of this e-mail is strictly prohibited and may be unlawful. Instead, please notify us immediately by return e-mail and promptly delete this message and its attachments from your computer system. We do not waive any work product or other applicable legal privilege(s) by the transmission of this message.
*******************************************

Re: [Math] FastMath missing methods from java.lang.Math...

Posted by Gilles Sadowski <gi...@gmail.com>.
Le jeu. 27 mai 2021 à 13:53, Erik Svensson <Er...@nasdaq.com> a écrit :
>
>
>
> On 2021-05-27, 11:59, "Gilles Sadowski" <gi...@gmail.com> wrote:
>
>     WARNING - External email; exercise caution.
>
>     Hi.
>
>     Le jeu. 27 mai 2021 à 11:32, Erik Svensson <Er...@nasdaq.com> a écrit :
>     >
>     > Howdy all!
>     >
>     >
>     >
>     > I’m comparing FastMath with java.lang.Math and I notice that FastMath is no longer Math-complete.
>     >
>     > Ie, jlM has methods that FastMath doesn’t have.
>
>     Incidentally, that's why the unit test suite fails when building with
>     JDK 9+ (when
>     "JAVA_HOME" is not set properly).
>
>
>     >
>     > FM is documented as ‘drop-in replacement’ so should the new jlM methods be added to FM?
>
>     Do you propose to write/port pure Java implementations for those?
>
> I can do that.

Great!
Please create a JIRA report.[1]

Thanks,
Gilles

[1] https://issues.apache.org/jira/browse/MATH

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [Math] FastMath missing methods from java.lang.Math...

Posted by Erik Svensson <Er...@nasdaq.com>.

On 2021-05-27, 11:59, "Gilles Sadowski" <gi...@gmail.com> wrote:

    WARNING - External email; exercise caution.

    Hi.

    Le jeu. 27 mai 2021 à 11:32, Erik Svensson <Er...@nasdaq.com> a écrit :
    >
    > Howdy all!
    >
    >
    >
    > I’m comparing FastMath with java.lang.Math and I notice that FastMath is no longer Math-complete.
    >
    > Ie, jlM has methods that FastMath doesn’t have.

    Incidentally, that's why the unit test suite fails when building with
    JDK 9+ (when
    "JAVA_HOME" is not set properly).


    >
    > FM is documented as ‘drop-in replacement’ so should the new jlM methods be added to FM?

    Do you propose to write/port pure Java implementations for those?

I can do that. 

/Erik

    Regards,
    Gilles

    > [...]

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
    For additional commands, e-mail: dev-help@commons.apache.org


*******************************************
CONFIDENTIALITY AND PRIVACY NOTICE: This e-mail and any attachments are for the exclusive and confidential use of the intended recipient and may constitute non-public information.  Personal data in this email is governed by our Privacy Policy at  https://www.nasdaq.com/privacy-statement  unless explicitly excluded from it; please see the section in the policy entitled “Situations Where This Privacy Policy Does Not Apply” for circumstances where different privacy terms govern emailed personal data.  If you received this e-mail in error, disclosing, copying, distributing or taking any action in reliance of this e-mail is strictly prohibited and may be unlawful. Instead, please notify us immediately by return e-mail and promptly delete this message and its attachments from your computer system. We do not waive any work product or other applicable legal privilege(s) by the transmission of this message.
*******************************************