You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by rmorrise <gi...@git.apache.org> on 2017/04/13 14:32:28 UTC
[GitHub] jena pull request #240: JENA-1321: Improved error handling so response body ...
GitHub user rmorrise opened a pull request:
https://github.com/apache/jena/pull/240
JENA-1321: Improved error handling so response body is not masked.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmorrise/jena master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit a717486d7728dd1b9636838f6bab3731264e2afe
Author: rmorrise <ru...@gmail.com>
Date: 2017-04-13T14:29:37Z
JENA-1321: Improved error handling so response body is not masked.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena issue #240: JENA-1321: Improved error handling so response body is not ...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/240
If that understanding is correct (and I now share it) then I agree with @afs's proposal, and I can make that change. @rmorrise ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena issue #240: JENA-1321: Improved error handling so response body is not ...
Posted by rmorrise <gi...@git.apache.org>.
Github user rmorrise commented on the issue:
https://github.com/apache/jena/pull/240
That works. Personally I prefer to see the original root cause but I guess people sometimes get distracted by long stack traces. If you are going to do that can you check the original exception's hierarchy for other props that might be needed like headers etc.?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena issue #240: JENA-1321: Improved error handling so response body is not ...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:
https://github.com/apache/jena/pull/240
To check my understanding: the root problem is that the `QueryExceptionHTTP` does not have the `HttpException.getResponse` available.
`QueryExceptionHTTP` can't be an `HttpException` and `QueryException` (separation of HTTP code from query handling).
If so, maybe it would be better to add the response body to the `QueryExceptionHTTP` - the removal of the `HttpException` level of exception removes a layer of unhelpful stacktrace (the local source of the `HttpException` is not relevant). By adding the error response to `QueryExceptionHTTP`, the response would be available still.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena issue #240: JENA-1321: Improved error handling so response body is not ...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/240
@rmorrise If you are satisfied with our work on JENA-1321, would you close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #240: JENA-1321: Improved error handling so response body ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena issue #240: JENA-1321: Improved error handling so response body is not ...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/240
`org.apache.jena.atlas.web.HttpException` only has `getResponseCode()`, `getStatusLine()`, and `getResponse()`. Wouldn't it work to just add those three to `QueryExceptionHTTP`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena issue #240: JENA-1321: Improved error handling so response body is not ...
Posted by rmorrise <gi...@git.apache.org>.
Github user rmorrise commented on the issue:
https://github.com/apache/jena/pull/240
Sounds good. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---