You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Paul Rogers (Code Review)" <ge...@cloudera.org> on 2018/11/30 20:51:04 UTC
[Impala-ASF-CR] IMPALA-7881 (Part 2): Visualize AST for easier debugging
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12015
Change subject: IMPALA-7881 (Part 2): Visualize AST for easier debugging
......................................................................
IMPALA-7881 (Part 2): Visualize AST for easier debugging
The AST visualizer has turned out to be very handy for debugging
analyzer issues. This patch contains another set of enhancements to make
it easier to use, including an easy way to visualize a node (and a few
of its descendents) or an entire tree from a debug session in Eclipse.
Testing: This is a test-only feature, it is not used from any production
code.
Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
---
M fe/src/test/java/org/apache/impala/util/treevis/AstPrinter.java
M fe/src/test/java/org/apache/impala/util/treevis/TreePrinter.java
M fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java
3 files changed, 159 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/12015/1
--
To view, visit http://gerrit.cloudera.org:8080/12015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
Gerrit-Change-Number: 12015
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
[Impala-ASF-CR] IMPALA-7881 (Part 2): Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12015 )
Change subject: IMPALA-7881 (Part 2): Visualize AST for easier debugging
......................................................................
IMPALA-7881 (Part 2): Visualize AST for easier debugging
The AST visualizer has turned out to be very handy for debugging
analyzer issues. This patch contains another set of enhancements to make
it easier to use, including an easy way to visualize a node (and a few
of its descendents) or an entire tree from a debug session in Eclipse.
Testing: This is a test-only feature, it is not used from any production
code.
Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
Reviewed-on: http://gerrit.cloudera.org:8080/12015
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/util/treevis/AstPrinter.java
M fe/src/test/java/org/apache/impala/util/treevis/TreePrinter.java
M fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java
3 files changed, 159 insertions(+), 69 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
Gerrit-Change-Number: 12015
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7881 (Part 2): Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12015 )
Change subject: IMPALA-7881 (Part 2): Visualize AST for easier debugging
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
Gerrit-Change-Number: 12015
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Dec 2018 21:59:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881 (Part 2): Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12015 )
Change subject: IMPALA-7881 (Part 2): Visualize AST for easier debugging
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3514/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
Gerrit-Change-Number: 12015
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Dec 2018 18:10:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881 (Part 2): Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12015 )
Change subject: IMPALA-7881 (Part 2): Visualize AST for easier debugging
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
Gerrit-Change-Number: 12015
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Dec 2018 18:10:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881 (Part 2): Visualize AST for easier debugging
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12015 )
Change subject: IMPALA-7881 (Part 2): Visualize AST for easier debugging
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
Gerrit-Change-Number: 12015
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Dec 2018 18:10:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881 (Part 2): Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12015 )
Change subject: IMPALA-7881 (Part 2): Visualize AST for easier debugging
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1481/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I409cabad9ec8c4dcf16c7e863dada58754d5eac1
Gerrit-Change-Number: 12015
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 21:25:17 +0000
Gerrit-HasComments: No