You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2021/12/03 18:06:50 UTC

[GitHub] [plc4x] sruehl commented on a change in pull request #265: Subscriptions for ADS in PLC4J

sruehl commented on a change in pull request #265:
URL: https://github.com/apache/plc4x/pull/265#discussion_r762143901



##########
File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec
##########
@@ -281,7 +281,8 @@
             // 4 bytes	The ADS server checks if the value changes in this time slice. The unit is 1ms
             [simple uint 32 'cycleTime']
             // 16bytes	Must be set to 0
-            [reserved   uint       128       '0x0000' ]
+            [reserved   uint       64       '0x0000' ]

Review comment:
       short question here: what was the reason for this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org