You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/01 04:34:44 UTC
[GitHub] [yunikorn-core] zhuqi-lucas opened a new pull request, #462: [YUNIKORN-1436] rename SimplePreemptor
zhuqi-lucas opened a new pull request, #462:
URL: https://github.com/apache/yunikorn-core/pull/462
### What is this PR for?
The daemon set preemption implementation uses a preemptor called SimplePreemptor. This is not a name that covers the task. It could also clash with the new preemption implementation for generic workload inter queue preemption.
Something like CriticalNodePreemptor or RequiredNodePreemptor would fit better.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1436
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #462: [YUNIKORN-1436] rename SimplePreemptor
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #462:
URL: https://github.com/apache/yunikorn-core/pull/462#issuecomment-1333161412
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/462?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#462](https://codecov.io/gh/apache/yunikorn-core/pull/462?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5f9725) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/4f7f709d17a9de74c14797273c697eac8594fc18?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f7f709) will **not change** coverage.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #462 +/- ##
=======================================
Coverage 72.81% 72.81%
=======================================
Files 67 67
Lines 9990 9990
=======================================
Hits 7274 7274
Misses 2474 2474
Partials 242 242
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/yunikorn-core/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.32% <0.00%> (ø)` | |
| [pkg/scheduler/objects/required\_node\_preemptor.go](https://codecov.io/gh/apache/yunikorn-core/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3JlcXVpcmVkX25vZGVfcHJlZW1wdG9yLmdv) | `98.83% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #462: [YUNIKORN-1436] rename SimplePreemptor
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #462: [YUNIKORN-1436] rename SimplePreemptor
URL: https://github.com/apache/yunikorn-core/pull/462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org