You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jianxia Chen <jc...@pivotal.io> on 2016/05/18 00:01:22 UTC

Review Request 47504: GEODE-1133 SeparateClassloaderTestRunner has to be re-implemented

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47504/
-----------------------------------------------------------

Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, and Udo Kohlmeyer.


Repository: geode


Description
-------

This class is no longer needed. So remove it.


Diffs
-----

  extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/junit/SeparateClassloaderTestRunner.java 4337f5a 

Diff: https://reviews.apache.org/r/47504/diff/


Testing
-------


Thanks,

Jianxia Chen


Re: Review Request 47504: GEODE-1133 SeparateClassloaderTestRunner has to be re-implemented

Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47504/#review133798
-----------------------------------------------------------


Ship it!




I don't know anything of this class. So if it is genuinely not used anymore, I'm happy that we remove it.

- Udo Kohlmeyer


On May 18, 2016, 12:01 a.m., Jianxia Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47504/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 12:01 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This class is no longer needed. So remove it.
> 
> 
> Diffs
> -----
> 
>   extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/junit/SeparateClassloaderTestRunner.java 4337f5a 
> 
> Diff: https://reviews.apache.org/r/47504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>


Re: Review Request 47504: GEODE-1133 SeparateClassloaderTestRunner has to be re-implemented

Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47504/#review133738
-----------------------------------------------------------


Ship it!




Ship It!

- Jens Deppe


On May 18, 2016, 12:01 a.m., Jianxia Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47504/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 12:01 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This class is no longer needed. So remove it.
> 
> 
> Diffs
> -----
> 
>   extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/junit/SeparateClassloaderTestRunner.java 4337f5a 
> 
> Diff: https://reviews.apache.org/r/47504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>