You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2019/02/20 19:53:38 UTC

[maven] 02/04: Corrected according to suggestions:

This is an automated email from the ASF dual-hosted git repository.

rfscholte pushed a commit to branch MNG-6572
in repository https://gitbox.apache.org/repos/asf/maven.git

commit c600f730fa2630b4ea6f829ac1be2ec2d09a961f
Author: Gabriel Belingueres <be...@gmail.com>
AuthorDate: Sat Jan 26 14:44:55 2019 -0300

    Corrected according to suggestions:
    
    - Changed LinkedList to ArrayDeque.
    - Moved import below license section in test.
---
 .../java/org/apache/maven/artifact/versioning/ComparableVersion.java  | 4 ++--
 .../org/apache/maven/artifact/versioning/ComparableVersionTest.java   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
index ad71ed0..c32760f 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
@@ -20,10 +20,10 @@ package org.apache.maven.artifact.versioning;
  */
 
 import java.math.BigInteger;
+import java.util.ArrayDeque;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Iterator;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.Locale;
 import java.util.Properties;
@@ -498,7 +498,7 @@ public class ComparableVersion
 
         ListItem list = items;
 
-        LinkedList<Item> stack = new LinkedList<>();
+        ArrayDeque<Item> stack = new ArrayDeque<>();
         stack.push( list );
 
         boolean isDigit = false;
diff --git a/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java b/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
index a5a2588..abe7d4a 100644
--- a/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
+++ b/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
@@ -1,7 +1,5 @@
 package org.apache.maven.artifact.versioning;
 
-import junit.framework.TestCase;
-
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
@@ -23,6 +21,8 @@ import junit.framework.TestCase;
 
 import java.util.Locale;
 
+import junit.framework.TestCase;
+
 /**
  * Test ComparableVersion.
  *