You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/09 04:31:38 UTC
[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #1306: HDDS-4051. Remove whitelist/blacklist terminology from Ozone
vivekratnavel opened a new pull request #1306:
URL: https://github.com/apache/hadoop-ozone/pull/1306
## What changes were proposed in this pull request?
- Replace whitelist/blacklist with allowlist/blocklist
There are still some occurrences of these terminologies in javascript frameworks like bootstrap and angular. Hopefully, these frameworks will update these terminologies in their future releases.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4051
## How was this patch tested?
No test is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1306: HDDS-4051. Remove whitelist/blacklist terminology from Ozone
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1306:
URL: https://github.com/apache/hadoop-ozone/pull/1306#issuecomment-671181683
Thanks @vivekratnavel for updating the patch, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1306: HDDS-4051. Remove whitelist/blacklist terminology from Ozone
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1306:
URL: https://github.com/apache/hadoop-ozone/pull/1306#discussion_r467545782
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java
##########
@@ -149,15 +149,15 @@ public synchronized void consumeOMEvents(OMUpdateEventBatch events,
}
/**
- * Blacklist tasks that failed reprocess step more than threshold times.
+ * Blocklist tasks that failed reprocess step more than threshold times.
* @param failedTasks list of failed tasks.
*/
- private void blacklistFailedTasks(List<String> failedTasks) {
+ private void blocklistFailedTasks(List<String> failedTasks) {
for (String taskName : failedTasks) {
LOG.info("Reprocess step failed for task {}.", taskName);
if (taskFailureCounter.get(taskName).incrementAndGet() >
TASK_FAILURE_THRESHOLD) {
- LOG.info("Blacklisting Task since it failed retry and " +
+ LOG.info("Blocklisting Task since it failed retry and " +
Review comment:
```suggestion
LOG.info("Ignoring task since it failed retry and " +
```
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java
##########
@@ -149,15 +149,15 @@ public synchronized void consumeOMEvents(OMUpdateEventBatch events,
}
/**
- * Blacklist tasks that failed reprocess step more than threshold times.
+ * Blocklist tasks that failed reprocess step more than threshold times.
Review comment:
```suggestion
* Ignore tasks that failed reprocess step more than threshold times.
```
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java
##########
@@ -94,7 +94,7 @@ public void registerTask(ReconOmTask task) {
* For every registered task, we try process step twice and then reprocess
* once (if process failed twice) to absorb the events. If a task has failed
* reprocess call more than 2 times across events, it is unregistered
- * (blacklisted).
+ * (blocklisted).
Review comment:
```suggestion
* (ignored).
```
##########
File path: hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestReconTaskControllerImpl.java
##########
@@ -131,7 +131,7 @@ public void testFailedTaskRetryLogic() throws Exception {
}
@Test
- public void testBadBehavedTaskBlacklisting() throws Exception {
+ public void testBadBehavedTaskBlocklisting() throws Exception {
Review comment:
```suggestion
public void testBadBehavedTaskIsIgnored() throws Exception {
```
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java
##########
@@ -149,15 +149,15 @@ public synchronized void consumeOMEvents(OMUpdateEventBatch events,
}
/**
- * Blacklist tasks that failed reprocess step more than threshold times.
+ * Blocklist tasks that failed reprocess step more than threshold times.
* @param failedTasks list of failed tasks.
*/
- private void blacklistFailedTasks(List<String> failedTasks) {
+ private void blocklistFailedTasks(List<String> failedTasks) {
Review comment:
```suggestion
private void ignoreFailedTasks(List<String> failedTasks) {
```
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java
##########
@@ -140,7 +140,7 @@ public synchronized void consumeOMEvents(OMUpdateEventBatch events,
results = executorService.invokeAll(tasks);
List<String> reprocessFailedTasks =
processTaskResults(results, events);
- blacklistFailedTasks(reprocessFailedTasks);
+ blocklistFailedTasks(reprocessFailedTasks);
Review comment:
```suggestion
ignoreFailedTasks(reprocessFailedTasks);
```
##########
File path: hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestReconTaskControllerImpl.java
##########
@@ -151,7 +151,7 @@ public void testBadBehavedTaskBlacklisting() throws Exception {
.get(dummyReconDBTask.getTaskName()));
}
- //Should be blacklisted now.
+ //Should be blocklisted now.
Review comment:
```suggestion
//Should be ignored now.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1306: HDDS-4051. Remove whitelist/blacklist terminology from Ozone
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1306:
URL: https://github.com/apache/hadoop-ozone/pull/1306#issuecomment-671464346
Thanks for the reviews @adoroszlai @avijayanhwx @amaliujia !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1306: HDDS-4051. Remove whitelist/blacklist terminology from Ozone
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1306:
URL: https://github.com/apache/hadoop-ozone/pull/1306#issuecomment-671085616
+1 on the ignore/ignorelist proposal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel merged pull request #1306: HDDS-4051. Remove whitelist/blacklist terminology from Ozone
Posted by GitBox <gi...@apache.org>.
vivekratnavel merged pull request #1306:
URL: https://github.com/apache/hadoop-ozone/pull/1306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org