You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2014/02/18 14:16:46 UTC
Re: Review Request 15435: Add long polling to asynchronous execution in
HiveServer2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15435/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 1:16 p.m.)
Review request for hive, Carl Steinbach and Thejas Nair.
Changes
-------
Rebased on trunk + feedback changes
Bugs: HIVE-5217
https://issues.apache.org/jira/browse/HIVE-5217
Repository: hive-git
Description
-------
Add long polling to asynchronous execution in HiveServer2
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7
service/src/java/org/apache/hive/service/cli/CLIService.java 56b357a
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java e973f83
service/src/java/org/apache/hive/service/cli/operation/Operation.java 58a28b6
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 03a37c8
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 8ec8d43
Diff: https://reviews.apache.org/r/15435/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 15435: Add long polling to asynchronous execution in
HiveServer2
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15435/#review34933
-----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
<https://reviews.apache.org/r/15435/#comment65313>
it would be better to call the constructor with more arguments from this one.
service/src/java/org/apache/hive/service/cli/operation/Operation.java
<https://reviews.apache.org/r/15435/#comment65311>
I think we should make runAsync field final, as it is not supposed to change.
service/src/java/org/apache/hive/service/cli/operation/Operation.java
<https://reviews.apache.org/r/15435/#comment65312>
it think it is cleaner to have this constructor call (instead of the other way around)
this(parentSession, opType, false);
That way initialization will be in one constructor, and it will be clear what all variables get initalized to.
- Thejas Nair
On Feb. 18, 2014, 1:16 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15435/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 1:16 p.m.)
>
>
> Review request for hive, Carl Steinbach and Thejas Nair.
>
>
> Bugs: HIVE-5217
> https://issues.apache.org/jira/browse/HIVE-5217
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add long polling to asynchronous execution in HiveServer2
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7
> service/src/java/org/apache/hive/service/cli/CLIService.java 56b357a
> service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java e973f83
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 58a28b6
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 03a37c8
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 8ec8d43
>
> Diff: https://reviews.apache.org/r/15435/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 15435: Add long polling to asynchronous execution in
HiveServer2
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15435/#review35050
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Feb. 20, 2014, 2:49 a.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15435/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 2:49 a.m.)
>
>
> Review request for hive, Carl Steinbach and Thejas Nair.
>
>
> Bugs: HIVE-5217
> https://issues.apache.org/jira/browse/HIVE-5217
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add long polling to asynchronous execution in HiveServer2
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7
> conf/hive-default.xml.template 0d08aa2
> service/src/java/org/apache/hive/service/cli/CLIService.java 56b357a
> service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java e973f83
> service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java c6e1692
> service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 8dc82ab
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 58a28b6
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 03a37c8
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 8ec8d43
>
> Diff: https://reviews.apache.org/r/15435/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 15435: Add long polling to asynchronous execution in
HiveServer2
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15435/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 2:49 a.m.)
Review request for hive, Carl Steinbach and Thejas Nair.
Changes
-------
Changes per feedback.
Bugs: HIVE-5217
https://issues.apache.org/jira/browse/HIVE-5217
Repository: hive-git
Description
-------
Add long polling to asynchronous execution in HiveServer2
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7
conf/hive-default.xml.template 0d08aa2
service/src/java/org/apache/hive/service/cli/CLIService.java 56b357a
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java e973f83
service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java c6e1692
service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 8dc82ab
service/src/java/org/apache/hive/service/cli/operation/Operation.java 58a28b6
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 03a37c8
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 8ec8d43
Diff: https://reviews.apache.org/r/15435/diff/
Testing
-------
Thanks,
Vaibhav Gumashta