You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/04/02 07:35:26 UTC

svn commit: r1888290 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java

Author: tilman
Date: Fri Apr  2 07:35:26 2021
New Revision: 1888290

URL: http://svn.apache.org/viewvc?rev=1888290&view=rev
Log:
PDFBOX-5134: speed up by returning empty bounding box instead of null if no triangles

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java?rev=1888290&r1=1888289&r2=1888290&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java Fri Apr  2 07:35:26 2021
@@ -241,6 +241,11 @@ abstract class PDTriangleBasedShadingTyp
             bounds.add(shadedTriangle.corner[1]);
             bounds.add(shadedTriangle.corner[2]);
         }
+        if (bounds == null)
+        {
+            // Speeds up files where triangles are empty, e.g. ghostscript file 690425
+            return new Rectangle2D.Float();
+        }
         return bounds;
     }
 }