[GitHub] [airflow] feluelle commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator

[GitBox <gi...@apache.org>]

feluelle commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator
URL: https://github.com/apache/airflow/pull/6153#discussion_r326624268
 
 

 ##########
 File path: airflow/contrib/operators/awsbatch_operator.py
 ##########
 @@ -81,8 +85,8 @@ class AWSBatchOperator(BaseOperator):
     template_fields = ('job_name', 'overrides',)
 
     @apply_defaults
-    def __init__(self, job_name, job_definition, job_queue, overrides, max_retries=4200,
-                 aws_conn_id=None, region_name=None, **kwargs):
+    def __init__(self, job_name, job_definition, job_queue, overrides, array_properties=None,
+                 max_retries=4200, aws_conn_id=None, region_name=None, **kwargs):
 
 Review comment:
   If you want/need to change the order of arguments of a function you should mention that in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md), because it is a backwards-incompatible change. Note that backwards-incompatible changes also won't make it in 1.10.x. The next version where it is possible to include this in, would be 2.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services