You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/12 05:00:06 UTC

[GitHub] [shardingsphere] terrymanu opened a new pull request, #20934: Reuse ShardingSpherePreconditions.checkNotNull

terrymanu opened a new pull request, #20934:
URL: https://github.com/apache/shardingsphere/pull/20934

   For #20036


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] TeslaCN commented on pull request #20934: Reuse ShardingSpherePreconditions.checkNotNull

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #20934:
URL: https://github.com/apache/shardingsphere/pull/20934#issuecomment-1247847459

   Creating an instance of Exception has expensive CPU overhead. Consider refactoring this to Supplier.
   
   ![image](https://user-images.githubusercontent.com/20503072/190370254-f7613870-fb4b-4401-a69e-ec863142f7fb.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #20934: Reuse ShardingSpherePreconditions.checkNotNull

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #20934:
URL: https://github.com/apache/shardingsphere/pull/20934


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org