You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pradeep Soundararajan <pr...@citrix.com> on 2013/02/12 13:16:35 UTC
Review Request: Added a global package name in the packaging script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9409/
-----------------------------------------------------------
Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
Description
-------
Added a global package name in the packaging script
Diffs
-----
packaging/centos63/package.sh 5b1bab49b615e504273be3fe69335c10782d009a
Diff: https://reviews.apache.org/r/9409/diff/
Testing
-------
Thanks,
Pradeep Soundararajan
Re: Review Request: Added a global package name in the packaging script
Posted by Prasanna Santhanam <Pr...@citrix.com>.
> On Feb. 21, 2013, 9:37 a.m., Hugo Trippaers wrote:
> > Ship It!
>
> Hugo Trippaers wrote:
> Commit in master 3279b4146526e2f4e77a06699887cb7ea141fc0b
>
> Cherry pick to 4.1 8b2aabe687fbee0a0806a2f9d9c0ca9a8d3cd2fd
Hey pradeep , can you close this review as submitted.
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9409/#review16839
-----------------------------------------------------------
On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2013, 12:16 p.m.)
>
>
> Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
>
>
> Description
> -------
>
> Added a global package name in the packaging script
>
>
> Diffs
> -----
>
> packaging/centos63/package.sh 5b1bab49b615e504273be3fe69335c10782d009a
>
> Diff: https://reviews.apache.org/r/9409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pradeep Soundararajan
>
>
RE: Review Request: Added a global package name in the packaging
script
Posted by Animesh Chaturvedi <an...@citrix.com>.
Hugo
Thanks for taking care of this patch
Animesh
> -----Original Message-----
> From: Hugo Trippaers [mailto:noreply@reviews.apache.org] On Behalf Of Hugo
> Trippaers
> Sent: Thursday, February 21, 2013 1:49 AM
> To: Wido den Hollander; Hugo Trippaers
> Cc: cloudstack; Pradeep Soundararajan
> Subject: Re: Review Request: Added a global package name in the packaging
> script
>
>
>
> > On Feb. 21, 2013, 9:37 a.m., Hugo Trippaers wrote:
> > > Ship It!
>
> Commit in master 3279b4146526e2f4e77a06699887cb7ea141fc0b
>
> Cherry pick to 4.1 8b2aabe687fbee0a0806a2f9d9c0ca9a8d3cd2fd
>
>
> - Hugo
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/#review16839
> -----------------------------------------------------------
>
>
> On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9409/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 12, 2013, 12:16 p.m.)
> >
> >
> > Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
> >
> >
> > Description
> > -------
> >
> > Added a global package name in the packaging script
> >
> >
> > Diffs
> > -----
> >
> > packaging/centos63/package.sh
> 5b1bab49b615e504273be3fe69335c10782d009a
> >
> > Diff: https://reviews.apache.org/r/9409/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Pradeep Soundararajan
> >
> >
Re: Review Request: Added a global package name in the packaging script
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
> On Feb. 21, 2013, 9:37 a.m., Hugo Trippaers wrote:
> > Ship It!
Commit in master 3279b4146526e2f4e77a06699887cb7ea141fc0b
Cherry pick to 4.1 8b2aabe687fbee0a0806a2f9d9c0ca9a8d3cd2fd
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9409/#review16839
-----------------------------------------------------------
On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2013, 12:16 p.m.)
>
>
> Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
>
>
> Description
> -------
>
> Added a global package name in the packaging script
>
>
> Diffs
> -----
>
> packaging/centos63/package.sh 5b1bab49b615e504273be3fe69335c10782d009a
>
> Diff: https://reviews.apache.org/r/9409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pradeep Soundararajan
>
>
Re: Review Request: Added a global package name in the packaging script
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9409/#review16839
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Trippaers
On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2013, 12:16 p.m.)
>
>
> Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
>
>
> Description
> -------
>
> Added a global package name in the packaging script
>
>
> Diffs
> -----
>
> packaging/centos63/package.sh 5b1bab49b615e504273be3fe69335c10782d009a
>
> Diff: https://reviews.apache.org/r/9409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pradeep Soundararajan
>
>
RE: Review Request: Added a global package name in the packaging
script
Posted by Pradeep Soundararajan <pr...@citrix.com>.
Hi Animesh,
Yes, right now there are situations where we have to change the name from cloud to cloudstack in plenty of places after the packaging name got changed from cloud to cloudstack.
One more example is here: https://reviews.apache.org/r/9435/diff/. This java file is having 'plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java' hardcoded values. I think there are many like that.
If would be good if we have the package name globally added in one place (in a property file or somewhere). We can leverage that variable in all the places including packaging scripts.
But adding the global name in the packaging script would not help. That will help only that particular script. We should be finding some place where we can add the package name globally.
Hugo/Wido, did you get a chance to look into this problem?
Thanks,
Pradeep S
-----Original Message-----
From: Animesh Chaturvedi
Sent: Thursday, February 14, 2013 9:01 AM
To: cloudstack-dev@incubator.apache.org; Pradeep Soundararajan; Wido den Hollander; Hugo Trippaers
Subject: RE: Review Request: Added a global package name in the packaging script
Pradeep
The patch looks fine, but do we really need the change? Wido/ Hugo can you review?
> -----Original Message-----
> From: Pradeep Soundararajan [mailto:noreply@reviews.apache.org] On
> Behalf Of Pradeep Soundararajan
> Sent: Tuesday, February 12, 2013 4:17 AM
> To: Wido den Hollander; Hugo Trippaers
> Cc: cloudstack; Pradeep Soundararajan
> Subject: Review Request: Added a global package name in the packaging
> script
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/
> -----------------------------------------------------------
>
> Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
>
>
> Description
> -------
>
> Added a global package name in the packaging script
>
>
> Diffs
> -----
>
> packaging/centos63/package.sh
> 5b1bab49b615e504273be3fe69335c10782d009a
>
> Diff: https://reviews.apache.org/r/9409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pradeep Soundararajan
RE: Review Request: Added a global package name in the packaging
script
Posted by Animesh Chaturvedi <an...@citrix.com>.
Pradeep
The patch looks fine, but do we really need the change? Wido/ Hugo can you review?
> -----Original Message-----
> From: Pradeep Soundararajan [mailto:noreply@reviews.apache.org] On Behalf
> Of Pradeep Soundararajan
> Sent: Tuesday, February 12, 2013 4:17 AM
> To: Wido den Hollander; Hugo Trippaers
> Cc: cloudstack; Pradeep Soundararajan
> Subject: Review Request: Added a global package name in the packaging script
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/
> -----------------------------------------------------------
>
> Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
>
>
> Description
> -------
>
> Added a global package name in the packaging script
>
>
> Diffs
> -----
>
> packaging/centos63/package.sh
> 5b1bab49b615e504273be3fe69335c10782d009a
>
> Diff: https://reviews.apache.org/r/9409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pradeep Soundararajan
RE: Review Request: Added a global package name in the packaging
script
Posted by Animesh Chaturvedi <an...@citrix.com>.
Hugo
A gentle reminder, let's close this patch
Animesh
> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Friday, February 15, 2013 9:53 AM
> To: cloudstack-dev@incubator.apache.org; Wido den Hollander; Hugo Trippaers
> Cc: Pradeep Soundararajan
> Subject: RE: Review Request: Added a global package name in the packaging
> script
>
> Hugo
>
> Can you review and commit the patch if satisfied
>
> > -----Original Message-----
> > From: Wido den Hollander [mailto:noreply@reviews.apache.org] On Behalf
> > Of Wido den Hollander
> > Sent: Wednesday, February 13, 2013 11:26 PM
> > To: Wido den Hollander; Hugo Trippaers
> > Cc: cloudstack; Pradeep Soundararajan
> > Subject: Re: Review Request: Added a global package name in the
> > packaging script
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9409/#review16567
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Seems fine with me, but Hugo has the most RPM knowledge, so I'll let
> > this up to him.
> >
> > From what I understand, package.sh hasn't been used that much.
> >
> > - Wido den Hollander
> >
> >
> > On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/9409/
> > > -----------------------------------------------------------
> > >
> > > (Updated Feb. 12, 2013, 12:16 p.m.)
> > >
> > >
> > > Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
> > >
> > >
> > > Description
> > > -------
> > >
> > > Added a global package name in the packaging script
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > packaging/centos63/package.sh
> > 5b1bab49b615e504273be3fe69335c10782d009a
> > >
> > > Diff: https://reviews.apache.org/r/9409/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > >
> > > Thanks,
> > >
> > > Pradeep Soundararajan
> > >
> > >
RE: Review Request: Added a global package name in the packaging
script
Posted by Animesh Chaturvedi <an...@citrix.com>.
Hugo
Can you review and commit the patch if satisfied
> -----Original Message-----
> From: Wido den Hollander [mailto:noreply@reviews.apache.org] On Behalf Of
> Wido den Hollander
> Sent: Wednesday, February 13, 2013 11:26 PM
> To: Wido den Hollander; Hugo Trippaers
> Cc: cloudstack; Pradeep Soundararajan
> Subject: Re: Review Request: Added a global package name in the packaging
> script
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/#review16567
> -----------------------------------------------------------
>
> Ship it!
>
>
> Seems fine with me, but Hugo has the most RPM knowledge, so I'll let this up to
> him.
>
> From what I understand, package.sh hasn't been used that much.
>
> - Wido den Hollander
>
>
> On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9409/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 12, 2013, 12:16 p.m.)
> >
> >
> > Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
> >
> >
> > Description
> > -------
> >
> > Added a global package name in the packaging script
> >
> >
> > Diffs
> > -----
> >
> > packaging/centos63/package.sh
> 5b1bab49b615e504273be3fe69335c10782d009a
> >
> > Diff: https://reviews.apache.org/r/9409/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Pradeep Soundararajan
> >
> >
RE: Review Request: Added a global package name in the packaging
script
Posted by Pradeep Soundararajan <pr...@citrix.com>.
This will help us to resolve the problem only with package.sh script but we have to find a way to resolve it globally by adding a global variable name.
Thanks,
Pradeep S
From: Wido den Hollander [mailto:noreply@reviews.apache.org] On Behalf Of Wido den Hollander
Sent: Thursday, February 14, 2013 12:56 PM
To: Wido den Hollander; Hugo Trippaers
Cc: cloudstack; Pradeep Soundararajan
Subject: Re: Review Request: Added a global package name in the packaging script
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9409/
Ship it!
Seems fine with me, but Hugo has the most RPM knowledge, so I'll let this up to him.
From what I understand, package.sh hasn't been used that much.
- Wido
On February 12th, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
By Pradeep Soundararajan.
Updated Feb. 12, 2013, 12:16 p.m.
Description
Added a global package name in the packaging script
Diffs
* packaging/centos63/package.sh (5b1bab49b615e504273be3fe69335c10782d009a)
View Diff<https://reviews.apache.org/r/9409/diff/>
Re: Review Request: Added a global package name in the packaging script
Posted by Wido den Hollander <wi...@widodh.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9409/#review16567
-----------------------------------------------------------
Ship it!
Seems fine with me, but Hugo has the most RPM knowledge, so I'll let this up to him.
>From what I understand, package.sh hasn't been used that much.
- Wido den Hollander
On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2013, 12:16 p.m.)
>
>
> Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
>
>
> Description
> -------
>
> Added a global package name in the packaging script
>
>
> Diffs
> -----
>
> packaging/centos63/package.sh 5b1bab49b615e504273be3fe69335c10782d009a
>
> Diff: https://reviews.apache.org/r/9409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pradeep Soundararajan
>
>