[GitHub] srowen commented on a change in pull request #23869: [SPARK-26967][CORE] Put MetricsSystem instance names together for clearer management

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23869: [SPARK-26967][CORE] Put MetricsSystem instance names together for clearer management
URL: https://github.com/apache/spark/pull/23869#discussion_r260329377
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/metrics/MetricsSystemSuite.scala
 ##########
 @@ -176,7 +178,7 @@ class MetricsSystemSuite extends SparkFunSuite with BeforeAndAfter with PrivateM
     conf.set("spark.app.id", appId)
     conf.set("spark.executor.id", executorId)
 
-    val instanceName = "testInstance"
+    val instanceName = MetricsSystemInstances.TEST
 
 Review comment:
   It's a change but I think you are correct here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org