You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by miguelaferreira <gi...@git.apache.org> on 2015/08/28 11:21:18 UTC
[GitHub] cloudstack pull request: Putting CglibThrowableRenderer.java back ...
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/758
Putting CglibThrowableRenderer.java back after it was removed in 83fd8f6
Also removing the entry 'log/' from .gitignore since that was the
culprit for the removal of the file.
This was detected in #714
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/miguelaferreira/cloudstack put-back-CglibThrowableRenderer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #758
----
commit 4c1a5f76570115e0dcc41c74c07c7d99546a8029
Author: Miguel Ferreira <mi...@me.com>
Date: 2015-08-28T09:18:44Z
Putting CglibThrowableRenderer.java back after it was removed in 83fd8f6
Also removing the entry 'log/' from .gitignore since that was the
culprit for the removal of the file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Putting CglibThrowableRenderer.java back ...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/758#issuecomment-135749238
:+1: merging..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Putting CglibThrowableRenderer.java back ...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/758#issuecomment-135744100
@wilderrodrigues that's the idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Putting CglibThrowableRenderer.java back ...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/758#issuecomment-135739973
So that will fix the exceptions we are getting when running jetty, right?
If so... LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Putting CglibThrowableRenderer.java
back ...
Posted by Rajani Karuturi <ra...@apache.org>.
This introduced an old findbugs issue as a new one because of which slow
build failed.
On Fri, Aug 28, 2015 at 17:27 PM, asfgit <gi...@git.apache.org> wrote:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org <javascript:;> or file
a JIRA ticket
with INFRA.
---
--
-
Sent from Windows Phone
~Rajani
[GitHub] cloudstack pull request: Putting CglibThrowableRenderer.java back ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---