You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/10 08:46:30 UTC
[GitHub] [kafka] chia7712 opened a new pull request #10860: MINOR: fix client_compatibility_features_test.py - DescribeAcls is al…
chia7712 opened a new pull request #10860:
URL: https://github.com/apache/kafka/pull/10860
Kraft already supports `DescribeAcls` (see 5b0c58ed53c420e93957369516f34346580dac95). Hence, the flag `describe-acls-supported` should be `True` rather than `False`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10860: MINOR: fix client_compatibility_features_test.py - DescribeAcls is al…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10860:
URL: https://github.com/apache/kafka/pull/10860#issuecomment-858436731
@rondagostino @ijuma Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #10860: MINOR: fix client_compatibility_features_test.py - DescribeAcls is al…
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10860:
URL: https://github.com/apache/kafka/pull/10860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10860: MINOR: fix client_compatibility_features_test.py - DescribeAcls is al…
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10860:
URL: https://github.com/apache/kafka/pull/10860#issuecomment-858624143
Do the system tests pass with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10860: MINOR: fix client_compatibility_features_test.py - DescribeAcls is al…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10860:
URL: https://github.com/apache/kafka/pull/10860#issuecomment-858649375
> Do the system tests pass with this change?
yep. This system test shows following error message without this patch.
```
java.lang.RuntimeException: Did not expect describeAclsSupported to be supported, but it was.
at org.apache.kafka.tools.ClientCompatibilityTest.tryFeature(ClientCompatibilityTest.java:525)
at org.apache.kafka.tools.ClientCompatibilityTest.tryFeature(ClientCompatibilityTest.java:509)
at org.apache.kafka.tools.ClientCompatibilityTest.testAdminClient(ClientCompatibilityTest.java:301)
at org.apache.kafka.tools.ClientCompatibilityTest.run(ClientCompatibilityTest.java:238)
at org.apache.kafka.tools.ClientCompatibilityTest.main(ClientCompatibilityTest.java:191)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org