[GitHub] [hbase] Reidddddd commented on a change in pull request #645: HBASE-22930 Set unique name to longCompactions/shortCompactions threads

[GitBox <gi...@apache.org>]

Reidddddd commented on a change in pull request #645: HBASE-22930 Set unique name to longCompactions/shortCompactions threads
URL: https://github.com/apache/hbase/pull/645#discussion_r326455790
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
 ##########
 @@ -131,11 +132,12 @@ public Thread newThread(Runnable r) {
   private void createSplitExcecutors() {
     final String n = Thread.currentThread().getName();
     int splitThreads = conf.getInt(SPLIT_THREADS, SPLIT_THREADS_DEFAULT);
+    final AtomicInteger splitThreadCounter = new AtomicInteger(0);
     this.splits =
         (ThreadPoolExecutor) Executors.newFixedThreadPool(splitThreads, new ThreadFactory() {
           @Override
 
 Review comment:
   Only one place not sure: shouldn't the counter be placed in `ThreadFactory`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services