[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4368: deprecates the /cdns/usage/overview endpoint

[GitBox <gi...@apache.org>]

mhoppa commented on a change in pull request #4368: deprecates the /cdns/usage/overview endpoint
URL: https://github.com/apache/trafficcontrol/pull/4368#discussion_r374811372
 
 

 ##########
 File path: traffic_ops/app/lib/Extensions/TrafficStats/API/CdnStats.pm
 ##########
 @@ -52,10 +52,10 @@ sub get_usage_overview {
 
 	my ( $rc, $result ) = $cstats->get_usage_overview();
 	if ( $rc == SUCCESS ) {
-		return $self->success($result);
+		return $self->deprecation_with_no_alternative(200, $result);
 	}
 	else {
-		return $self->alert($result);
+		return $self->deprecation_with_no_alternative(500, $result);
 
 Review comment:
   nit but the alert perl method returned a 400 response code instead of a 500 this should match that, once that is changed I believe this PR is ready to go

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services