You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Don Bosco Durai <bo...@apache.org> on 2015/03/31 02:26:00 UTC
Review Request 32671: RANGER-178 - Ranger Admin server side code for
Solr plugin service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32671/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-178
https://issues.apache.org/jira/browse/RANGER-178
Repository: ranger
Description
-------
RANGER-178 - Ranger Admin server side code for Solr plugin service
Diffs
-----
agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json PRE-CREATION
plugin-solr/.gitignore PRE-CREATION
plugin-solr/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
plugin-solr/conf/ranger-policymgr-ssl.xml PRE-CREATION
plugin-solr/conf/ranger-solr-audit-changes.cfg PRE-CREATION
plugin-solr/conf/ranger-solr-audit.xml PRE-CREATION
plugin-solr/conf/ranger-solr-security-changes.cfg PRE-CREATION
plugin-solr/conf/ranger-solr-security.xml PRE-CREATION
plugin-solr/pom.xml PRE-CREATION
plugin-solr/scripts/install.properties PRE-CREATION
plugin-solr/scripts/solr-plugin-install.properties PRE-CREATION
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java PRE-CREATION
plugin-solr/src/main/java/org/apache/ranger/services/solr/RangerServiceSolr.java PRE-CREATION
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java PRE-CREATION
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java PRE-CREATION
pom.xml a93cd73
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 8e6aa3f
security-admin/src/main/resources/sample.xa_system.properties 8043ef8
src/main/assembly/plugin-solr.xml PRE-CREATION
Diff: https://reviews.apache.org/r/32671/diff/
Testing
-------
Tested manually
Thanks,
Don Bosco Durai
Re: Review Request 32671: RANGER-178 - Ranger Admin server side code
for Solr plugin service
Posted by Don Bosco Durai <bo...@apache.org>.
> On March 31, 2015, 2:29 a.m., Madhan Neethiraj wrote:
> > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json, line 10
> > <https://reviews.apache.org/r/32671/diff/1/?file=910186#file910186line10>
> >
> > To enable easier handling of resource additions, it is recommended to use levels like 10, 20 i.e. spaced.
Done
> On March 31, 2015, 2:29 a.m., Madhan Neethiraj wrote:
> > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json, line 17
> > <https://reviews.apache.org/r/32671/diff/1/?file=910186#file910186line17>
> >
> > matcherOptions value is now specified as JSON map. Please refer other service-def for samples and update.
Done
> On March 31, 2015, 2:29 a.m., Madhan Neethiraj wrote:
> > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json, line 56
> > <https://reviews.apache.org/r/32671/diff/1/?file=910186#file910186line56>
> >
> > Or is it to represent 'Delegated Admin' in Ranger? If yes, please remove 'admin' as an accessType.
> >
> > If 'admin' is a permission in Solr - does this permission include (imply) other permissions as well? If yes, please add 'impliedAccessTypes' (please refer hbase service-def)
This is Solr Admin. Solr Admin has different set of permissions and not necessary read/write to solr collection. It would be mostly create/delete collection (similar to DBA). I am calling this as solr_admin (Solr Admin)
> On March 31, 2015, 2:29 a.m., Madhan Neethiraj wrote:
> > plugin-solr/conf/ranger-solr-audit-changes.cfg, line 36
> > <https://reviews.apache.org/r/32671/diff/1/?file=910190#file910190line36>
> >
> > No Kafka properties and few Solr properties are missing (compared to other plugins). Please review.
Solr properties are deliberate. Both are actually deliberate. In HDFS I had commented Kafka properties. I will review the rest
> On March 31, 2015, 2:29 a.m., Madhan Neethiraj wrote:
> > plugin-solr/conf/ranger-solr-audit.xml, line 186
> > <https://reviews.apache.org/r/32671/diff/1/?file=910191#file910191line186>
> >
> > properties for Solr and Kafka destinations missing. Please review.
Added
> On March 31, 2015, 2:29 a.m., Madhan Neethiraj wrote:
> > plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java, line 62
> > <https://reviews.apache.org/r/32671/diff/1/?file=910199#file910199line62>
> >
> > Please check this resource-name (column) with the one given in service-def (field).
Done
- Don Bosco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32671/#review78312
-----------------------------------------------------------
On March 31, 2015, 12:25 a.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32671/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 12:25 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-178
> https://issues.apache.org/jira/browse/RANGER-178
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-178 - Ranger Admin server side code for Solr plugin service
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json PRE-CREATION
> plugin-solr/.gitignore PRE-CREATION
> plugin-solr/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-solr/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-solr/conf/ranger-solr-audit-changes.cfg PRE-CREATION
> plugin-solr/conf/ranger-solr-audit.xml PRE-CREATION
> plugin-solr/conf/ranger-solr-security-changes.cfg PRE-CREATION
> plugin-solr/conf/ranger-solr-security.xml PRE-CREATION
> plugin-solr/pom.xml PRE-CREATION
> plugin-solr/scripts/install.properties PRE-CREATION
> plugin-solr/scripts/solr-plugin-install.properties PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/services/solr/RangerServiceSolr.java PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java PRE-CREATION
> pom.xml a93cd73
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 8e6aa3f
> security-admin/src/main/resources/sample.xa_system.properties 8043ef8
> src/main/assembly/plugin-solr.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32671/diff/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 32671: RANGER-178 - Ranger Admin server side code
for Solr plugin service
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32671/#review78312
-----------------------------------------------------------
agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json
<https://reviews.apache.org/r/32671/#comment126847>
To enable easier handling of resource additions, it is recommended to use levels like 10, 20 i.e. spaced.
agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json
<https://reviews.apache.org/r/32671/#comment126849>
matcherOptions value is now specified as JSON map. Please refer other service-def for samples and update.
agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json
<https://reviews.apache.org/r/32671/#comment126850>
Or is it to represent 'Delegated Admin' in Ranger? If yes, please remove 'admin' as an accessType.
If 'admin' is a permission in Solr - does this permission include (imply) other permissions as well? If yes, please add 'impliedAccessTypes' (please refer hbase service-def)
plugin-solr/conf/ranger-solr-audit-changes.cfg
<https://reviews.apache.org/r/32671/#comment126855>
No Kafka properties and few Solr properties are missing (compared to other plugins). Please review.
plugin-solr/conf/ranger-solr-audit.xml
<https://reviews.apache.org/r/32671/#comment126852>
properties for Solr and Kafka destinations missing. Please review.
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java
<https://reviews.apache.org/r/32671/#comment126860>
Please check this resource-name (column) with the one given in service-def (field).
- Madhan Neethiraj
On March 31, 2015, 12:25 a.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32671/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 12:25 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-178
> https://issues.apache.org/jira/browse/RANGER-178
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-178 - Ranger Admin server side code for Solr plugin service
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json PRE-CREATION
> plugin-solr/.gitignore PRE-CREATION
> plugin-solr/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-solr/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-solr/conf/ranger-solr-audit-changes.cfg PRE-CREATION
> plugin-solr/conf/ranger-solr-audit.xml PRE-CREATION
> plugin-solr/conf/ranger-solr-security-changes.cfg PRE-CREATION
> plugin-solr/conf/ranger-solr-security.xml PRE-CREATION
> plugin-solr/pom.xml PRE-CREATION
> plugin-solr/scripts/install.properties PRE-CREATION
> plugin-solr/scripts/solr-plugin-install.properties PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/services/solr/RangerServiceSolr.java PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java PRE-CREATION
> pom.xml a93cd73
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 8e6aa3f
> security-admin/src/main/resources/sample.xa_system.properties 8043ef8
> src/main/assembly/plugin-solr.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32671/diff/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 32671: RANGER-178 - Ranger Admin server side code
for Solr plugin service
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32671/#review78328
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 31, 2015, 3:58 a.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32671/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 3:58 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-178
> https://issues.apache.org/jira/browse/RANGER-178
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-178 - Ranger Admin server side code for Solr plugin service
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json PRE-CREATION
> plugin-solr/conf/ranger-solr-audit.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32671/diff/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 32671: RANGER-178 - Ranger Admin server side code
for Solr plugin service
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32671/
-----------------------------------------------------------
(Updated March 31, 2015, 3:58 a.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Incorporated feedback from Madhan
Bugs: RANGER-178
https://issues.apache.org/jira/browse/RANGER-178
Repository: ranger
Description
-------
RANGER-178 - Ranger Admin server side code for Solr plugin service
Diffs (updated)
-----
agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json PRE-CREATION
plugin-solr/conf/ranger-solr-audit.xml PRE-CREATION
Diff: https://reviews.apache.org/r/32671/diff/
Testing
-------
Tested manually
Thanks,
Don Bosco Durai
Re: Review Request 32671: RANGER-178 - Ranger Admin server side code
for Solr plugin service
Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32671/#review78326
-----------------------------------------------------------
Ship it!
Ship It!
- Selvamohan Neethiraj
On March 30, 2015, 11:51 p.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32671/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 11:51 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-178
> https://issues.apache.org/jira/browse/RANGER-178
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-178 - Ranger Admin server side code for Solr plugin service
>
>
> Diffs
> -----
>
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32671/diff/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 32671: RANGER-178 - Ranger Admin server side code
for Solr plugin service
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32671/
-----------------------------------------------------------
(Updated March 31, 2015, 3:51 a.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
RANGER-178 - Changed column to field
Bugs: RANGER-178
https://issues.apache.org/jira/browse/RANGER-178
Repository: ranger
Description
-------
RANGER-178 - Ranger Admin server side code for Solr plugin service
Diffs (updated)
-----
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java PRE-CREATION
Diff: https://reviews.apache.org/r/32671/diff/
Testing
-------
Tested manually
Thanks,
Don Bosco Durai