You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/07 14:10:55 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #6393:
[AIRFLOW-5718] Add SFTPToGoogleCloudStorageOperator
potiuk commented on a change in pull request #6393: [AIRFLOW-5718] Add SFTPToGoogleCloudStorageOperator
URL: https://github.com/apache/airflow/pull/6393#discussion_r343668903
##########
File path: tests/operators/test_sftp_to_gcs.py
##########
@@ -0,0 +1,213 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import os
+import unittest
+
+from airflow.exceptions import AirflowException
+from airflow.operators.sftp_to_gcs import SFTPToGoogleCloudStorageOperator
+from tests.compat import mock
+
+TASK_ID = "test-gcs-to-sftp-operator"
+GCP_CONN_ID = "GCP_CONN_ID"
+SFTP_CONN_ID = "SFTP_CONN_ID"
+DELEGATE_TO = "DELEGATE_TO"
+
+DEFAULT_MIME_TYPE = "application/octet-stream"
+
+TEST_BUCKET = "test-bucket"
+SOURCE_OBJECT_WILDCARD_FILENAME = "main_dir/test_object*.json"
+SOURCE_OBJECT_NO_WILDCARD = "main_dir/test_object3.json"
+SOURCE_OBJECT_MULTIPLE_WILDCARDS = "main_dir/csv/*/test_*.csv"
+
+SOURCE_FILES_LIST = [
+ "main_dir/test_object1.txt",
+ "main_dir/test_object2.txt",
+ "main_dir/test_object3.json",
+ "main_dir/sub_dir/test_object1.txt",
+ "main_dir/sub_dir/test_object2.txt",
+ "main_dir/sub_dir/test_object3.json",
+]
+
+DESTINATION_PATH_DIR = "destination_dir"
+DESTINATION_PATH_FILE = "destination_dir/copy.txt"
+
+
+# pylint: disable=unused-argument
+class TestSFTPToGoogleCloudStorageOperator(unittest.TestCase):
+ @mock.patch("airflow.operators.sftp_to_gcs.GoogleCloudStorageHook")
+ @mock.patch("airflow.operators.sftp_to_gcs.SFTPHook")
+ def test_execute_copy_single_file(self, sftp_hook, gcs_hook):
+ task = SFTPToGoogleCloudStorageOperator(
+ task_id=TASK_ID,
+ source_path=SOURCE_OBJECT_NO_WILDCARD,
+ destination_bucket=TEST_BUCKET,
+ destination_path=DESTINATION_PATH_FILE,
+ move_object=False,
+ gcp_conn_id=GCP_CONN_ID,
+ sftp_conn_id=SFTP_CONN_ID,
+ delegate_to=DELEGATE_TO,
+ )
+ task.execute(None)
+ gcs_hook.assert_called_once_with(
+ gcp_conn_id=GCP_CONN_ID, delegate_to=DELEGATE_TO
+ )
+ sftp_hook.assert_called_once_with(SFTP_CONN_ID)
+
+ sftp_hook.return_value.retrieve_file.assert_called_once_with(
+ os.path.join(SOURCE_OBJECT_NO_WILDCARD), mock.ANY
+ )
+
+ gcs_hook.return_value.upload.assert_called_once_with(
+ bucket_name=TEST_BUCKET,
+ object_name=DESTINATION_PATH_FILE,
+ filename=mock.ANY,
+ mime_type=DEFAULT_MIME_TYPE,
+ )
+
+ sftp_hook.return_value.delete_file.assert_not_called()
+
+ @mock.patch("airflow.operators.sftp_to_gcs.GoogleCloudStorageHook")
+ @mock.patch("airflow.operators.sftp_to_gcs.SFTPHook")
+ def test_execute_move_single_file(self, sftp_hook, gcs_hook):
+ task = SFTPToGoogleCloudStorageOperator(
+ task_id=TASK_ID,
+ source_path=SOURCE_OBJECT_NO_WILDCARD,
+ destination_bucket=TEST_BUCKET,
+ destination_path=DESTINATION_PATH_FILE,
+ move_object=True,
+ gcp_conn_id=GCP_CONN_ID,
+ sftp_conn_id=SFTP_CONN_ID,
+ delegate_to=DELEGATE_TO,
+ )
+ task.execute(None)
+ gcs_hook.assert_called_once_with(
+ gcp_conn_id=GCP_CONN_ID, delegate_to=DELEGATE_TO
+ )
+ sftp_hook.assert_called_once_with(SFTP_CONN_ID)
+
+ sftp_hook.return_value.retrieve_file.assert_called_once_with(
+ os.path.join(SOURCE_OBJECT_NO_WILDCARD), mock.ANY
+ )
+
+ gcs_hook.return_value.upload.assert_called_once_with(
+ bucket_name=TEST_BUCKET,
+ object_name=DESTINATION_PATH_FILE,
+ filename=mock.ANY,
+ mime_type=DEFAULT_MIME_TYPE,
+ )
+
+ sftp_hook.return_value.delete_file.assert_called_once_with(
+ SOURCE_OBJECT_NO_WILDCARD
+ )
+
+ @mock.patch("airflow.operators.sftp_to_gcs.GoogleCloudStorageHook")
+ @mock.patch("airflow.operators.sftp_to_gcs.SFTPHook")
+ def test_execute_copy_with_wildcard(self, sftp_hook, gcs_hook):
+ sftp_hook.return_value.get_tree_map.return_value = [
+ ["main_dir/test_object3.json", "main_dir/sub_dir/test_object3.json"],
+ [],
+ [],
+ ]
+
+ task = SFTPToGoogleCloudStorageOperator(
+ task_id=TASK_ID,
+ source_path=SOURCE_OBJECT_WILDCARD_FILENAME,
+ destination_bucket=TEST_BUCKET,
+ destination_path=DESTINATION_PATH_DIR,
+ move_object=True,
+ gcp_conn_id=GCP_CONN_ID,
+ sftp_conn_id=SFTP_CONN_ID,
+ delegate_to=DELEGATE_TO,
+ )
+ task.execute(None)
+
+ sftp_hook.return_value.get_tree_map.assert_called_with(
+ "main_dir", prefix="main_dir/test_object", delimiter=".json"
+ )
+
+ sftp_hook.return_value.retrieve_file.assert_has_calls(
+ [
+ mock.call("main_dir/test_object3.json", mock.ANY),
+ mock.call("main_dir/sub_dir/test_object3.json", mock.ANY),
+ ]
+ )
+
+ gcs_hook.return_value.upload.assert_has_calls(
+ [
+ mock.call(
+ bucket_name=TEST_BUCKET,
+ object_name="destination_dir/test_object3.json",
+ mime_type=DEFAULT_MIME_TYPE,
+ filename=mock.ANY,
+ ),
+ mock.call(
+ bucket_name=TEST_BUCKET,
+ object_name="destination_dir/sub_dir/test_object3.json",
+ mime_type=DEFAULT_MIME_TYPE,
+ filename=mock.ANY,
+ ),
+ ]
+ )
+
+ @mock.patch("airflow.operators.sftp_to_gcs.GoogleCloudStorageHook")
+ @mock.patch("airflow.operators.sftp_to_gcs.SFTPHook")
+ def test_execute_move_with_wildcard(self, sftp_hook, gcs_hook):
+ sftp_hook.return_value.get_tree_map.return_value = [
+ ["main_dir/test_object3.json", "main_dir/sub_dir/test_object3.json"],
+ [],
+ [],
+ ]
+
+ gcs_hook.return_value.list.return_value = SOURCE_FILES_LIST[:2]
+ task = SFTPToGoogleCloudStorageOperator(
+ task_id=TASK_ID,
+ source_path=SOURCE_OBJECT_WILDCARD_FILENAME,
+ destination_bucket=TEST_BUCKET,
+ destination_path=DESTINATION_PATH_DIR,
+ move_object=True,
+ gcp_conn_id=GCP_CONN_ID,
+ sftp_conn_id=SFTP_CONN_ID,
+ delegate_to=DELEGATE_TO,
+ )
+ task.execute(None)
+
+ sftp_hook.return_value.delete_file.assert_has_calls(
+ [
+ mock.call("main_dir/test_object3.json"),
+ mock.call("main_dir/sub_dir/test_object3.json"),
+ ]
+ )
+
+ @mock.patch("airflow.operators.sftp_to_gcs.GoogleCloudStorageHook")
+ @mock.patch("airflow.operators.sftp_to_gcs.SFTPHook")
+ def test_execute_more_than_one_wildcard_exception(self, sftp_hook, gcs_hook):
+ task = SFTPToGoogleCloudStorageOperator(
+ task_id=TASK_ID,
+ source_path=SOURCE_OBJECT_MULTIPLE_WILDCARDS,
+ destination_bucket=TEST_BUCKET,
+ destination_path=DESTINATION_PATH_FILE,
+ move_object=False,
+ gcp_conn_id=GCP_CONN_ID,
+ sftp_conn_id=SFTP_CONN_ID,
+ delegate_to=DELEGATE_TO,
+ )
+ with self.assertRaises(AirflowException):
Review comment:
Would be great to check the exception message here. We had in the past problems that different exception was raised and we did not realise it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services