[jira] Resolved: (CASSANDRA-612) Fix Findbugs: Condition misuse

["Stu Hood (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood resolved CASSANDRA-612.
--------------------------------

    Resolution: Invalid

The warnings related to use of await() outside of a loop are false positives due to SimpleCondition changing the contract of Condition, and the streaming code's use of timed await() has been removed.

> Fix Findbugs: Condition misuse
> ------------------------------
>
>                 Key: CASSANDRA-612
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-612
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>         Attachments: await.txt
>
>
> We frequently misuse Condition objects, although there is no guarantee that all of the uses are abuses.
> On the other hand, findbugs did find two issues that are likely to be bugs: not checking the return value of await(timeout), and calling wait() rather than await() on a Condition. See the attached.
> In order to find unused method parameters for CASSANDRA-608, I ran FindBugs against Cassandra, and found a few interesting issues we ought to explore (but not the unused method params, oi.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.