Re: [PR] feat: Support `TimestampNs` and TimestampTzNs` in bucket transform [iceberg-rust]

["kevinjqliu (via GitHub)" <gi...@apache.org>]

kevinjqliu commented on code in PR #1150:
URL: https://github.com/apache/iceberg-rust/pull/1150#discussion_r2023158926


##########
crates/iceberg/src/transform/bucket.rs:
##########
@@ -167,6 +167,16 @@ impl TransformFunction for Bucket {
                 .downcast_ref::<arrow_array::TimestampMicrosecondArray>()
                 .unwrap()
                 .unary(|v| self.bucket_timestamp(v)),
+            DataType::Time64(TimeUnit::Nanosecond) => input

Review Comment:
   in pyiceberg, `TimestampNanoType` in converted to micros precision before bucketing. This is to ensure that `TimestampType` and `TimestampNanoType` are transformed to the same value
   
   https://github.com/apache/iceberg-python/blob/4d4714a46241d0d89519a2a605dbce27b713a60e/pyiceberg/transforms.py#L322-L340
   
   I think we should add a test to ensure this here too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org