You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2022/10/31 11:02:07 UTC

[doris] branch master updated: [fix](nereids) query cannot execution when both nereids enable and fallback to legacy planner are set to false (#13787)

This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 18be77af64 [fix](nereids) query cannot execution when both nereids enable and fallback to legacy planner are set to false (#13787)
18be77af64 is described below

commit 18be77af64abd0fec701de09d6574410689a369b
Author: minghong <en...@gmail.com>
AuthorDate: Mon Oct 31 19:02:01 2022 +0800

    [fix](nereids) query cannot execution when both nereids enable and fallback to legacy planner are set to false (#13787)
    
    when enable_nereids_planner=false and enable_fallback_to_origin=false, FE throws exception for all select statement.
    Expected: when enable_nereids_planner=false, all valid query execution success
---
 .../src/main/java/org/apache/doris/qe/ConnectProcessor.java      | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java b/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
index 847bb5baf0..38e37052fd 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
@@ -282,10 +282,11 @@ public class ConnectProcessor {
                     ctx.resetReturnRows();
                 }
                 parsedStmt = stmts.get(i);
-                if (parsedStmt instanceof SelectStmt) {
-                    if (!ctx.getSessionVariable().enableFallbackToOriginalPlanner) {
-                        throw new Exception(String.format("SQL: %s", parsedStmt.toSql()), nereidsParseException);
-                    }
+                if (parsedStmt instanceof SelectStmt && nereidsParseException != null
+                        && ctx.getSessionVariable().isEnableNereidsPlanner()
+                        && !ctx.getSessionVariable().enableFallbackToOriginalPlanner) {
+                    throw new Exception(String.format("nereids cannot anaylze sql, and fall-back disabled: %s",
+                                parsedStmt.toSql()), nereidsParseException);
                 }
                 parsedStmt.setOrigStmt(new OriginStatement(originStmt, i));
                 parsedStmt.setUserInfo(ctx.getCurrentUserIdentity());


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org