You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/18 10:38:23 UTC
[GitHub] [flink] twalthr commented on a change in pull request #14420: [FLINK-19981][core][table] Add name-based field mode for Row
twalthr commented on a change in pull request #14420:
URL: https://github.com/apache/flink/pull/14420#discussion_r545746283
##########
File path: flink-core/src/test/java/org/apache/flink/testutils/DeeplyEqualsChecker.java
##########
@@ -90,8 +88,6 @@ private boolean deepEquals0(Object e1, Object e2) {
return deepEqualsArray(e1, e2);
} else if (e1 instanceof Tuple && e2 instanceof Tuple) {
return deepEqualsTuple((Tuple) e1, (Tuple) e2);
- } else if (e1 instanceof Row && e2 instanceof Row) {
Review comment:
Yes, the Row implementation supports that now. And if a custom implementation is still needed the checker allows to override it if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org