[jira] [Comment Edited] (SLING-4701) SlingAuthenticator.isAnonAllowed matches for all paths starting with the same characters

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987247#comment-14987247 ] 

Konrad Windszus edited comment on SLING-4701 at 11/3/15 1:17 PM:
-----------------------------------------------------------------

I applied a slightly different version of [~santiagozky]'s documentation patch. Please check the new documentation at https://sling.apache.org/documentation/the-sling-engine/authentication/authentication-framework.html#anonymous-login. 
I am closing this bug as "Invalid" as a change here would not be backward-compatible and there is a valid workaround for the original issue.


was (Author: kwin):
I applied a slightly different version of [~santiagozky]'s patch. Please check the new documentation at https://sling.apache.org/documentation/the-sling-engine/authentication/authentication-framework.html#anonymous-login. 
I am closing this bug as "Invalid" as a change here would not be backward-compatible and there is a valid workaround for the original issue.

> SlingAuthenticator.isAnonAllowed matches for all paths starting with the same characters
> ----------------------------------------------------------------------------------------
>
>                 Key: SLING-4701
>                 URL: https://issues.apache.org/jira/browse/SLING-4701
>             Project: Sling
>          Issue Type: Bug
>          Components: Authentication
>    Affects Versions: Auth Core 1.3.6
>            Reporter: Lars Krapf
>            Assignee: Konrad Windszus
>              Labels: authentication
>         Attachments: SlingAuthenticator.patch, sling-4701-doc.patch
>
>
> The SlingAuthenticator check if anonymous access is allowed compares paths with String.startsWith. If the holder.path does not end with a '/' it will erroneously match a different path that starts with the same characters, even if it is not a descendant of the first path. 
> Example:
> - Allow anonymous acces on '/'
> - Deny anonymous access on a path '/blubb'  
> -> Authentication is enforced on a request to '/blubb-blah' - which is wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)