Re: [Announce] New Committer and PMC Member, David North

[David North <dt...@corefiling.co.uk>]

Thanks everyone.

I've attempted to make the smallest non-trivial fix I could find to dip
my toe in the water:

https://bz.apache.org/bugzilla/show_bug.cgi?id=55410

A few questions:

Should I be able to log into bugzilla using my ASF credentials? It
doesn't seem to accept them, but obviously the account I've been
reporting bugs as previously doesn't let me edit the assignee, etc.

Do we have a convention for cross-linking bugs and commits? The way I
was taught to do it is to put the revision number of the fix on the bug
(which I see has turned into a convenient hyperlink) and the full URL of
the bug being worked on in the commit message.

How do people usually work with the project? For this trivial fix I
worked directly off an SVN checkout, but I assume git-svn is the way to
go in order to allow public review of branches / pull requests via
github when working on bigger changes?

Thanks,
David

On 27/05/15 20:55, Dominik Stadler wrote:
> Hello David,
>
> welcome on board, nice to get additional hands on board, just let us
> know on the dev-list whenever you are curious about how things work!
>
> Regards... Dominik.
>
> On Thu, May 21, 2015 at 9:32 PM, Nick Burch <ni...@apache.org> wrote:
>> Hi All
>>
>> On behalf of the Apache POI PMC, we're pleased to announce that David North
>> has been elected as a committer and PMC member for the project!
>>
>> For anyone else thinking of getting involved, there's some information
>> available on the project website at http://poi.apache.org/guidelines.html
>> along with some general advice at http://community.apache.org/newcomers/ .
>> The project welcomes all kinds of contributions, from patches to
>> documentation to community support to improvements to fixes, all we ask is
>> that you make a positive contribution for a sustained period. Hopefully some
>> more of you can be added in this year too :)
>>
>> Nick
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@poi.apache.org
>> For additional commands, e-mail: user-help@poi.apache.org
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>


-- 
David North, Technical Lead, CoreFiling Limited
http://www.corefiling.com
Phone: +44-1865-203192


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

Re: [Announce] New Committer and PMC Member, David North

[Dominik Stadler <do...@gmx.at>]

Hi,

On Wed, Jun 3, 2015 at 3:10 PM, David North <dt...@corefiling.co.uk> wrote:
> Thanks everyone.
>
...
>
> How do people usually work with the project? For this trivial fix I
> worked directly off an SVN checkout, but I assume git-svn is the way to
> go in order to allow public review of branches / pull requests via
> github when working on bigger changes?
>

Yes, git-svn works well for me, but I also use a SVN checkout on
another machine. Git-svn allows me to keep changes that are only
necessary locally as well as unfinished work in local branches. I use
"git rebase" a lot to rebase to latest trunk continuously. I did not
try to merge it with the git-repository that is online at github, I
would expect it to have different object-ids and thus not merge well.
But locally git svn rebase and git svn dcommit will happily push back
changes to SVN, some other things need to be observed to make it work
without hassle, I can give more details if you are interested.

Currently larger work is sometimes done on separate SVN-Branches where
others can take a look, however I think unless the changes are quite
intrusive like the sl_common branch, doing the changes incrementally
step-by-step on trunk is the preferred approach as
branching/merging/conflict-resolution quickly gets cumbersome with
SVN.

Dominik.

> Thanks,
> David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

Re: [Announce] New Committer and PMC Member, David North

[Nick Burch <ap...@gagravarr.org>]

On Wed, 3 Jun 2015, David North wrote:
> Should I be able to log into bugzilla using my ASF credentials? It 
> doesn't seem to accept them, but obviously the account I've been 
> reporting bugs as previously doesn't let me edit the assignee, etc.

They have different account databases. So, just keep going with your 
existing account. I think we normally just leave things assigned to POI 
Developer. I think as long as you can change priorities, tags, close etc, 
you should have all you need

(If you need versions or components changing/adding, just ask on the list. 
Only a handful of people have bugzilla admin karma, which is cross-project 
so infra don't give it out too widely)


> Do we have a convention for cross-linking bugs and commits? The way I 
> was taught to do it is to put the revision number of the fix on the bug 
> (which I see has turned into a convenient hyperlink) and the full URL of 
> the bug being worked on in the commit message.

Normally just put the bugzilla number in the commit message, eg 'Fix NPE 
#12345' or 'Fix from Jim smith from #54321 - Fix NPE', then in the 
bugzilla entry mention the revision number when you close it eg 'Thanks, 
fixed in r1234'


> How do people usually work with the project? For this trivial fix I 
> worked directly off an SVN checkout, but I assume git-svn is the way to 
> go in order to allow public review of branches / pull requests via 
> github when working on bigger changes?

Small changes just commit to trunk, or create a patch from trunk for 
review for later commit. For slightly larger changes, create a branch 
somewhere (svn or github), then merge. For large changes, create a longer 
lived branch in svn and commit until ready to merge.

Commits need to be done to svn (using svn or git-svn), but your working 
copy can be either svn or git as you prefer. In case you hadn't spotted, 
details of the read-only git and github mirrors are given at 
http://git.apache.org/ and http://poi.apache.org/subversion.html

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org