You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Gary Gregory <ga...@gmail.com> on 2018/11/08 17:51:04 UTC
Checkstyle over examples
I think that if we update to the Maven Checkstyle 3.0.0 plugin we will be
able to run checkstyle over our examples.
Gary
Re: Checkstyle over examples
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Nov 8, 2018 at 12:15 PM Oleg Kalnichevski <ol...@apache.org> wrote:
> On Thu, 2018-11-08 at 10:51 -0700, Gary Gregory wrote:
> > I think that if we update to the Maven Checkstyle 3.0.0 plugin we
> > will be
> > able to run checkstyle over our examples.
> >
> > Gary
>
> They _do_ get style checked.
>
> https://github.com/apache/httpcomponents-core/blob/master/pom.xml#L229
>
> Their style definition is intentionally laxer (no mandatory final) in
> order to keep code conciser.
>
Different code style for different directories is an utterly confusing
double standard :-(
Gary
> It is truly regrettable you have added 'final' to all the examples.
>
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Checkstyle over examples
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Thu, 2018-11-08 at 10:51 -0700, Gary Gregory wrote:
> I think that if we update to the Maven Checkstyle 3.0.0 plugin we
> will be
> able to run checkstyle over our examples.
>
> Gary
They _do_ get style checked.
https://github.com/apache/httpcomponents-core/blob/master/pom.xml#L229
Their style definition is intentionally laxer (no mandatory final) in
order to keep code conciser.
It is truly regrettable you have added 'final' to all the examples.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org