You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/11/15 15:08:56 UTC
[GitHub] [ozone] dombizita commented on pull request #3952: HDDS-7468. Recon: clusterState API Changes for adding missingContainerCount
dombizita commented on PR #3952:
URL: https://github.com/apache/ozone/pull/3952#issuecomment-1315446886
Thanks for updating your patch. I just found [getUnhealthyContainersSummary()](https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/ContainerHealthSchemaManager.java#L97) inside `ContainerHealthSchemaManager`, which would give us the number of unhealthy containers in each state (it returns a list of `UnhealthyContainersSummary`, so we could use only the `MISSING`'s count). Maybe we could use this instead of [getUnhealthyContainers()](https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/ContainerHealthSchemaManager.java#L68), it doesn't have a limit parameter, but I think it is less performance to only retrieve the count for each state (correct me if I am wrong) and in this case we could display the exact value for missing container count. Let me know what you think of this. @devmadhuu @smengcl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org