You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/26 14:14:30 UTC
[GitHub] [bookkeeper] Shoothzj opened a new pull request, #3425: Bump puppycrawl checkstyle version from 6.19 to 7.8.2
Shoothzj opened a new pull request, #3425:
URL: https://github.com/apache/bookkeeper/pull/3425
### Changes
Bump puppycrawl checkstyle version to 7.8.2. Fix violation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3425: Bump puppycrawl checkstyle version from 6.19 to 7.8.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3425:
URL: https://github.com/apache/bookkeeper/pull/3425#issuecomment-1198791894
The CI failures are not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3425: Bump puppycrawl checkstyle version from 6.19 to 7.8.2
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3425:
URL: https://github.com/apache/bookkeeper/pull/3425#issuecomment-1198265665
Why not upgrade to a higher version? 7.8.2 was released in 2017.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3425: Bump puppycrawl checkstyle version from 6.19 to 7.8.2
Posted by GitBox <gi...@apache.org>.
dlg99 commented on code in PR #3425:
URL: https://github.com/apache/bookkeeper/pull/3425#discussion_r932758271
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ZooKeeperCluster.java:
##########
@@ -59,7 +59,7 @@ public interface ZooKeeperCluster {
void killCluster() throws Exception;
- void sleepCluster(int time, final TimeUnit timeUnit, final CountDownLatch l)
+ void sleepCluster(int time, TimeUnit timeUnit, CountDownLatch l)
Review Comment:
is it related to puppycrawl version upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj merged pull request #3425: Bump puppycrawl checkstyle version from 6.19 to 7.8.2
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #3425:
URL: https://github.com/apache/bookkeeper/pull/3425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3425: Bump puppycrawl checkstyle version from 6.19 to 7.8.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3425:
URL: https://github.com/apache/bookkeeper/pull/3425#issuecomment-1198380814
> Why not upgrade to a higher version? 7.8.2 was released in 2017.
@hangc0276 It changes a lot. I think maybe we can change this periodically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on a diff in pull request #3425: Bump puppycrawl checkstyle version from 6.19 to 7.8.2
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3425:
URL: https://github.com/apache/bookkeeper/pull/3425#discussion_r932765163
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ZooKeeperCluster.java:
##########
@@ -59,7 +59,7 @@ public interface ZooKeeperCluster {
void killCluster() throws Exception;
- void sleepCluster(int time, final TimeUnit timeUnit, final CountDownLatch l)
+ void sleepCluster(int time, TimeUnit timeUnit, CountDownLatch l)
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org