[GitHub] [arrow] mapleFU commented on a diff in pull request #13874: ARROW-17408: [c++] Fixing C++20 compile warning using operator==(const T&, const T&)

[GitBox <gi...@apache.org>]

mapleFU commented on code in PR #13874:
URL: https://github.com/apache/arrow/pull/13874#discussion_r945844571


##########
cpp/src/arrow/util/compare.h:
##########
@@ -54,6 +54,10 @@ class EqualityComparable {
   bool operator==(const T& other) const { return cast().Equals(other); }
   bool operator!=(const T& other) const { return !(cast() == other); }
 
+  friend bool operator==(const T& a, const T& b) {
+    return a.Equals(b);
+  }

Review Comment:
   It's ok on my PC, I'll try it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org