You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/10/09 15:26:27 UTC
[kudu-CR] [hms] Fix testSyncDisabled on Hive 4
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16574
Change subject: [hms] Fix testSyncDisabled on Hive 4
......................................................................
[hms] Fix testSyncDisabled on Hive 4
In Hive 4 the MetastoreDefaultTransformer ensures that
external tables don’t use the warehouse as a their storage location.
Kudu doesn’t actually use this location, but the location must still be
valid.
This patch changes the test to re-fetch the table after creation
to get the location after translation has occured. It also deep
copies the table before altering to ensure any unwanted properties
are not copied over.
Change-Id: I2dc12f350794314325736be581888cb69be917a1
---
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
1 file changed, 5 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/16574/1
--
To view, visit http://gerrit.cloudera.org:8080/16574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dc12f350794314325736be581888cb69be917a1
Gerrit-Change-Number: 16574
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [hms] Fix testSyncDisabled on Hive 4
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [hms] Fix testSyncDisabled on Hive 4
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2dc12f350794314325736be581888cb69be917a1
Gerrit-Change-Number: 16574
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hms] Fix testSyncDisabled on Hive 4
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16574 )
Change subject: [hms] Fix testSyncDisabled on Hive 4
......................................................................
[hms] Fix testSyncDisabled on Hive 4
In Hive 4 the MetastoreDefaultTransformer ensures that
external tables don’t use the warehouse as a their storage location.
Kudu doesn’t actually use this location, but the location must still be
valid.
This patch changes the test to re-fetch the table after creation
to get the location after translation has occured. It also deep
copies the table before altering to ensure any unwanted properties
are not copied over.
Change-Id: I2dc12f350794314325736be581888cb69be917a1
Reviewed-on: http://gerrit.cloudera.org:8080/16574
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
1 file changed, 5 insertions(+), 7 deletions(-)
Approvals:
Grant Henke: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dc12f350794314325736be581888cb69be917a1
Gerrit-Change-Number: 16574
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hms] Fix testSyncDisabled on Hive 4
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16574 )
Change subject: [hms] Fix testSyncDisabled on Hive 4
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dc12f350794314325736be581888cb69be917a1
Gerrit-Change-Number: 16574
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Oct 2020 16:46:02 +0000
Gerrit-HasComments: No
[kudu-CR] [hms] Fix testSyncDisabled on Hive 4
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16574 )
Change subject: [hms] Fix testSyncDisabled on Hive 4
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dc12f350794314325736be581888cb69be917a1
Gerrit-Change-Number: 16574
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Oct 2020 18:41:55 +0000
Gerrit-HasComments: No