You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/16 11:08:21 UTC
[PR] Align JsonEngine method names with YamlEngine [shardingsphere]
terrymanu opened a new pull request, #39488:
URL: https://github.com/apache/shardingsphere/pull/39488
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align JsonEngine method names with YamlEngine [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39488:
URL: https://github.com/apache/shardingsphere/pull/39488#issuecomment-5307146137
### Result
**Review Result: Mergeable**
The PR consistently renames all `JsonEngine` methods and updates every repository call site without changing behavior.
### Evidence
- GitHub and local triple-dot scopes match: 33 files.
- No remaining references to the removed method names exist at the PR head.
- `infra/util` tests pass: 69 tests, 0 failures.
- No correctness blockers identified.
### Coverage
Reviewed head `8544858cbab2efe8adec088a2999d94712b9ea16` against base `ead5993a981309a124f067eb6d89c077c69e7b59`.
Reviewed all 33 changed files across the JSON API rename cluster, including production callers, unit tests, E2E tests, and integration parser code. Completed root-cause, blast-radius/contracts, tests/runtime, and convergence reviews.
This is a code-scope result only; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align JsonEngine method names with YamlEngine [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39488:
URL: https://github.com/apache/shardingsphere/pull/39488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org