You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kazuyukitanimura (via GitHub)" <gi...@apache.org> on 2024/07/30 16:42:16 UTC
[PR] fix: Remove castting on decimals with a small precision to decimal256 [datafusion-comet]
kazuyukitanimura opened a new pull request, #741:
URL: https://github.com/apache/datafusion-comet/pull/741
## Which issue does this PR close?
Part of #670
## Rationale for this change
This PR improves the native execution performance on decimals with a small precision
## What changes are included in this PR?
This PR changes not to promote decimal128 to decimal256 if the precisions are small enough
## How are these changes tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove castting on decimals with a small precision to decimal256 [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on PR #741:
URL: https://github.com/apache/datafusion-comet/pull/741#issuecomment-2258776596
```
OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Mac OS X 14.5
Apple M1 Max
TPCDS Micro Benchmarks: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
add_many_decimals 10883 11268 365 26.5 37.8 1.0X
add_many_decimals: Comet (Scan) 13924 14097 309 20.7 48.3 0.8X
add_many_decimals: Comet (Scan, Exec) 12476 12570 111 23.1 43.3 0.9X
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove castting on decimals with a small precision to decimal256 [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on PR #741:
URL: https://github.com/apache/datafusion-comet/pull/741#issuecomment-2263656950
Thank you @andygrove merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove castting on decimals with a small precision to decimal256 [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on PR #741:
URL: https://github.com/apache/datafusion-comet/pull/741#issuecomment-2261547567
@comphead @huaxingao @parthchandra @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove castting on decimals with a small precision to decimal256 [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #741:
URL: https://github.com/apache/datafusion-comet/pull/741#issuecomment-2259306828
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/741?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 53.75%. Comparing base [(`ded3dd6`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/ded3dd6703fe62c1ad2b3cb9034975aec410ff32?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a14f888`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/a14f8880b8ef4dd3cc6ae5c6cfda65bb115c3a8f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 8 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #741 +/- ##
=============================================
+ Coverage 33.57% 53.75% +20.17%
+ Complexity 830 813 -17
=============================================
Files 110 107 -3
Lines 42608 10273 -32335
Branches 9352 1934 -7418
=============================================
- Hits 14306 5522 -8784
+ Misses 25347 3774 -21573
+ Partials 2955 977 -1978
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/741?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove castting on decimals with a small precision to decimal256 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #741:
URL: https://github.com/apache/datafusion-comet/pull/741#issuecomment-2260646950
I created a criterion benchmark for decimal_div inhttps://github.com/apache/datafusion-comet/pull/743.
The results look great for the changes in this PR.
```
decimal_div time: [5.3281 µs 5.3370 µs 5.3485 µs]
change: [-94.767% -94.727% -94.685%] (p = 0.00 < 0.05)
Performance has improved.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove castting on decimals with a small precision to decimal256 [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura merged PR #741:
URL: https://github.com/apache/datafusion-comet/pull/741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org