You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/24 18:46:22 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #12692: ARROW-16005: [Java] Fix ArrayConsumer when using ArrowVectorIterator

lidavidm commented on code in PR #12692:
URL: https://github.com/apache/arrow/pull/12692#discussion_r880842894


##########
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/ArrayConsumer.java:
##########
@@ -90,13 +97,12 @@ public void consume(ResultSet resultSet) throws SQLException, IOException {
         int count = 0;
         try (ResultSet rs = array.getResultSet()) {
           while (rs.next()) {
-            ensureInnerVectorCapacity(innerVectorIndex + count + 1);

Review Comment:
   I'm still not entirely convinced we can remove `innerVectorIndex` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org