You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/04/22 23:54:35 UTC

[GitHub] [avro] kojiromike commented on a change in pull request #847: Avro-2785: Update specs on how unions encoded

kojiromike commented on a change in pull request #847:
URL: https://github.com/apache/avro/pull/847#discussion_r413410884



##########
File path: doc/src/content/xdocs/spec.xml
##########
@@ -546,7 +546,7 @@
 
           <section id="union_encoding">
             <title>Unions</title>
-            <p>A union is encoded by first writing a <code>long</code>
+            <p>A union is encoded by first writing an <code>int</code>

Review comment:
       Until the needed consideration for c/++ are done, I think we should include a parenthetical for that case. Something like _(this can theoretically be a long, and is allowed as such in C and C++, but we don't anticipate unions with 215M members)_.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org